chrome/common/spellcheck_marker.h - Issue 15318004: Store feedback for spellcheck results from spelling service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/spellcheck_marker.h

Issue 15318004: Store feedback for spellcheck results from spelling service (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Move typedefs to feedback.h Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_COMMON_SPELLCHECK_MARKER_H_	5 #ifndef CHROME_COMMON_SPELLCHECK_MARKER_H_

6 #define CHROME_COMMON_SPELLCHECK_MARKER_H_	6 #define CHROME_COMMON_SPELLCHECK_MARKER_H_

7	7

8 struct SpellCheckMarker {	8 struct SpellCheckMarker {

	9 // IPC requires a default constructor.

	10 SpellCheckMarker() : hash(0), offset(0) {}
	groby-ooo-7-16 2013/05/23 19:10:50 Please set offset to MAX_UINT - I'd like it to be Please set offset to MAX_UINT - I'd like it to be very clear that this is a default-constructed object. (Might want to double check with security folks if that introduces problems. I wouldn't think so, but better safe than sorry :) please use gerrit instead 2013/05/23 19:50:47 Changed to MAX_UINT and asked Chris. Show quoted text On 2013/05/23 19:10:50, groby wrote: > Please set offset to MAX_UINT - I'd like it to be very clear that this is a > default-constructed object. > > (Might want to double check with security folks if that introduces problems. I > wouldn't think so, but better safe than sorry :) Changed to MAX_UINT and asked Chris.
	11

9 SpellCheckMarker(uint32 hash, size_t offset) : hash(hash), offset(offset) {}	12 SpellCheckMarker(uint32 hash, size_t offset) : hash(hash), offset(offset) {}

10	13

11 uint32 hash;	14 uint32 hash;

12 size_t offset;	15 size_t offset;

13 };	16 };

14	17

15 #endif // CHROME_COMMON_SPELLCHECK_MARKER_H_	18 #endif // CHROME_COMMON_SPELLCHECK_MARKER_H_

OLD	NEW