Store feedback for spellcheck results from spelling service

chrome/browser/spellchecker/feedback_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/spellchecker/feedback.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace spellcheck {
 
 namespace {
@@ skipping 41 matching lines @@
   Misspelling* removed_misspelling =
       feedback_.GetMisspelling(kRemovedMisspellingHash);
   EXPECT_NE(static_cast<Misspelling*>(NULL), removed_misspelling);
   EXPECT_TRUE(removed_misspelling->action.IsFinal());
   Misspelling* remaining_misspelling =
       feedback_.GetMisspelling(kRemainingMisspellingHash);
   EXPECT_NE(static_cast<Misspelling*>(NULL), remaining_misspelling);
   EXPECT_FALSE(remaining_misspelling->action.IsFinal());
 }
 
+// Duplicate misspellings should not be finalized.
+TEST_F(FeedbackTest, DuplicateMisspellingFinalization) {

[groby-ooo-7-16, 2013/05/23 19:10:50]

Why a new test?

[please use gerrit instead, 2013/05/23 19:50:47]

This test verifies that I fixed a bug. If FeedbackSender added the same
misspelling to Feedback twice, then the misspelling would get finalized
prematurely.

+  AddMisspelling(kRendererProcessId, kMisspellingHash);
+  AddMisspelling(kRendererProcessId, kMisspellingHash);
+  std::vector<uint32> remaining_markers(1, kMisspellingHash);
+  feedback_.FinalizeRemovedMisspellings(kRendererProcessId, remaining_markers);
+  std::vector<Misspelling> misspellings = feedback_.GetAllMisspellings();
+  EXPECT_EQ(static_cast<size_t>(1), misspellings.size());
+  EXPECT_FALSE(misspellings[0].action.IsFinal());
+}
+
 // Misspellings should be associated with a renderer.
 TEST_F(FeedbackTest, RendererHasMisspellings) {
   EXPECT_FALSE(feedback_.RendererHasMisspellings(kRendererProcessId));
   AddMisspelling(kRendererProcessId, kMisspellingHash);
   EXPECT_TRUE(feedback_.RendererHasMisspellings(kRendererProcessId));
 }
 
 // Should be able to retrieve misspellings in renderer.
 TEST_F(FeedbackTest, GetMisspellingsInRenderer) {
   AddMisspelling(kRendererProcessId, kMisspellingHash);
@@ skipping 84 matching lines @@
 // Should be able to clear all misspellings.
 TEST_F(FeedbackTest, ClearFeedback) {
   AddMisspelling(kRendererProcessId, kMisspellingHash);
   AddMisspelling(kRendererProcessId + 1, kMisspellingHash + 1);
   EXPECT_FALSE(feedback_.Empty());
   feedback_.Clear();
   EXPECT_TRUE(feedback_.Empty());
 }
 
 }  // namespace spellcheck