Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1531763002: Temporary workaround to make VM bots greener. (Closed)

Created:
5 years ago by Florian Schneider
Modified:
5 years ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Temporary workaround to make VM bots greener. The reason are data races at isolate creation/shutdown. Further investigation to fix the root cause needed. TBR=johnmccutchan@google.com, BUG= Committed: https://github.com/dart-lang/sdk/commit/61f190eebe554bcbea7bbee58cffcd2a80f13f7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M runtime/bin/isolate_data.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Florian Schneider
5 years ago (2015-12-16 14:25:03 UTC) #3
Florian Schneider
Committed patchset #1 (id:1) manually as 61f190eebe554bcbea7bbee58cffcd2a80f13f7b (presubmit successful).
5 years ago (2015-12-16 14:30:35 UTC) #5
Cutch
Why were both #if 0 blocks needed? The IsolateData destructor isn't new is it?
5 years ago (2015-12-16 14:41:19 UTC) #6
Florian Schneider
5 years ago (2015-12-16 15:05:36 UTC) #7
Message was sent while issue was closed. 
On 2015/12/16 14:41:19, Cutch wrote:
> Why were both #if 0 blocks needed? The IsolateData destructor isn't new is it?

There are two crashes - one where Timeline has been shutdown and the static
streams are already freed, the other where the strings in IsolateData are
already destroyed.

Powered by Google App Engine
This is Rietveld 408576698