Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1531753002: [turbofan] Add support for CreateIterResultObject. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for CreateIterResultObject. Introduce JSCreateIterResultObject operator, as a way to optimize the %_CreateIterResultObject intrinsic, which is used to provide uniform, non-polymorphic result objects for iterators (and generators). We cannot utilize the existing JSCreate operator here, because there's no constructor function for iterator result objects (as required by the spec). R=mstarzinger@chromium.org Committed: https://crrev.com/01662f1b1da9e71a2161d831528060e41b6c6716 Cr-Commit-Position: refs/heads/master@{#32901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -38 lines) Patch
M src/compiler/access-builder.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +23 lines, -22 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +33 lines, -0 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +17 lines, -16 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
5 years ago (2015-12-16 13:29:37 UTC) #1
mvstanton
lgtm
5 years ago (2015-12-16 14:11:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531753002/1
5 years ago (2015-12-16 14:16:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 14:26:02 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/01662f1b1da9e71a2161d831528060e41b6c6716 Cr-Commit-Position: refs/heads/master@{#32901}
5 years ago (2015-12-16 14:26:34 UTC) #8
Michael Starzinger
5 years ago (2015-12-16 15:29:34 UTC) #9
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698