Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 153173008: Make sure that allocation site scratchpad entries get recorded. (Closed)

Created:
6 years, 10 months ago by Hannes Payer (out of office)
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make sure that allocation site scratchpad entries get recorded. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19268

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/heap.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
6 years, 10 months ago (2014-02-11 10:41:57 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/153173008/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/153173008/diff/1/src/heap.cc#newcode3626 src/heap.cc:3626: // candidates into account. Maybe make it explicit ...
6 years, 10 months ago (2014-02-11 10:48:48 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/153173008/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/153173008/diff/1/src/heap.cc#newcode3626 src/heap.cc:3626: // candidates into account. On 2014/02/11 10:48:48, Michael Starzinger ...
6 years, 10 months ago (2014-02-11 10:52:20 UTC) #3
Hannes Payer (out of office)
6 years, 10 months ago (2014-02-11 10:52:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19268 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698