Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: gpu/command_buffer/service/program_manager.cc

Issue 153173002: Add a gpu driver bug workaround to count in all varyings in packing check. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/program_manager.cc
diff --git a/gpu/command_buffer/service/program_manager.cc b/gpu/command_buffer/service/program_manager.cc
index 725b3666fb5edecc79084cea9241b039bc80fee2..a49b387693b1eec37d026ee6638f3eeeadd7bece 100644
--- a/gpu/command_buffer/service/program_manager.cc
+++ b/gpu/command_buffer/service/program_manager.cc
@@ -116,6 +116,11 @@ bool IsBuiltInVarying(const std::string& name) {
return false;
}
+bool IsGpuDriverBugWorkaroundsDisabled() {
+ return CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kDisableGpuDriverBugWorkarounds);
+}
Ken Russell (switch to Gerrit) 2014/02/06 22:13:30 This function's unused and must be deleted (the un
Zhenyao Mo 2014/02/06 23:42:40 Done.
+
} // anonymous namespace.
Program::UniformInfo::UniformInfo()
@@ -522,6 +527,7 @@ void ProgramManager::DoCompileShader(
bool Program::Link(ShaderManager* manager,
ShaderTranslator* vertex_translator,
ShaderTranslator* fragment_translator,
+ Program::VaryingsPackingOption varyings_packing_option,
const ShaderCacheCallback& shader_callback) {
ClearLinkStatus();
if (!CanLink()) {
@@ -552,7 +558,7 @@ bool Program::Link(ShaderManager* manager,
set_log_info(ProcessLogInfo(info_log).c_str());
return false;
}
- if (!CheckVaryingsPacking()) {
+ if (!CheckVaryingsPacking(varyings_packing_option)) {
set_log_info("Varyings over maximum register limit");
return false;
}
@@ -1097,7 +1103,8 @@ bool Program::DetectGlobalNameConflicts(std::string* conflicting_name) const {
return false;
}
-bool Program::CheckVaryingsPacking() const {
+bool Program::CheckVaryingsPacking(
+ Program::VaryingsPackingOption option) const {
DCHECK(attached_shaders_[0] &&
attached_shaders_[0]->shader_type() == GL_VERTEX_SHADER &&
attached_shaders_[1] &&
@@ -1112,13 +1119,14 @@ bool Program::CheckVaryingsPacking() const {
for (ShaderTranslator::VariableMap::const_iterator iter =
fragment_varyings->begin();
iter != fragment_varyings->end(); ++iter) {
- if (!iter->second.static_use)
+ if (!iter->second.static_use && option == kCountOnlyStaticallyUsed)
continue;
if (!IsBuiltInVarying(iter->first)) {
ShaderTranslator::VariableMap::const_iterator vertex_iter =
vertex_varyings->find(iter->first);
if (vertex_iter == vertex_varyings->end() ||
- !vertex_iter->second.static_use)
+ (!vertex_iter->second.static_use &&
+ option == kCountOnlyStaticallyUsed))
continue;
}
« no previous file with comments | « gpu/command_buffer/service/program_manager.h ('k') | gpu/command_buffer/service/program_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698