Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 1531703002: Include <algorithm> if you use functions from <algorithm>. (Closed)

Created:
5 years ago by Daniel Bratell
Modified:
5 years ago
Reviewers:
tdresser
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include <algorithm> if you use functions from <algorithm>. I'm trying to remove #include <algorithm> from common headers because it takes a long time to compile, but then code that actually need <algorithm> need to include that header themselves. This will bring no functional change. BUG=563433 Committed: https://crrev.com/dedc29ee183f334c2ffe487d8bea8887f5bb22fc Cr-Commit-Position: refs/heads/master@{#365524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/events/blink/blink_event_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/blink/input_scroll_elasticity_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Daniel Bratell
tdresser, can you please take a look? Just adding two missing includes so that I ...
5 years ago (2015-12-16 12:37:50 UTC) #2
tdresser
LGTM
5 years ago (2015-12-16 13:12:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531703002/1
5 years ago (2015-12-16 13:17:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 14:22:09 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-16 14:23:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dedc29ee183f334c2ffe487d8bea8887f5bb22fc
Cr-Commit-Position: refs/heads/master@{#365524}

Powered by Google App Engine
This is Rietveld 408576698