test/unittests/interpreter/bytecode-array-builder-unittest.cc - Issue 1531693002: [Interpreter] Implement ForIn in bytecode graph builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 1531693002: [Interpreter] Implement ForIn in bytecode graph builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0009-phi

Patch Set: Minor clean-up/simplication in Runtime_InterpreterForInPrepare. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

index d69f5ac5aea422306e07da1eed3d895d1051c646..39e9994708889b344ca550c8e1eebf307da6aa21 100644

--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

@@ -216,7 +216,10 @@ TEST_F(BytecodeArrayBuilderTest, AllBytecodesGenerated) {

.Throw()

.Bind(&after_throw);

- builder.ForInPrepare(reg).ForInDone(reg).ForInNext(reg, reg);

+ builder.ForInPrepare(reg, reg, reg)

+ .ForInDone(reg, reg)

+ .ForInNext(reg, reg, reg, reg)

+ .ForInStep(reg);

// Wide constant pool loads

for (int i = 0; i < 256; i++) {

« no previous file with comments | « test/cctest/interpreter/test-bytecode-generator.cc ('k') | no next file » | no next file with comments »