Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1531683002: [proxies] Implement Proxy.name (Closed)

Created:
5 years ago by Camillo Bruni
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Implement Proxy.name LOG=n BUG=v8:1543 Committed: https://crrev.com/654efd0a4dd33360c4fd385ca744b0766ff0a883 Cr-Commit-Position: refs/heads/master@{#32891}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531683002/1
5 years ago (2015-12-16 09:56:30 UTC) #2
Camillo Bruni
PTAL seems like we missed Proxy.name === 'Proxy' ;), thanks test262
5 years ago (2015-12-16 09:57:08 UTC) #4
Toon Verwaest
arg of course. lgtm
5 years ago (2015-12-16 10:26:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-16 10:44:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531683002/1
5 years ago (2015-12-16 11:23:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 11:24:53 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-16 11:25:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/654efd0a4dd33360c4fd385ca744b0766ff0a883
Cr-Commit-Position: refs/heads/master@{#32891}

Powered by Google App Engine
This is Rietveld 408576698