Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Issue 153163002: [VSAddin] Don't require both 2010 and 2012 to be installed. (Closed)

Created:
6 years, 10 months ago by Sam Clegg
Modified:
6 years, 10 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[VSAddin] Don't require both 2010 and 2012 to be installed. R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1570

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M visual_studio/NativeClientVSAddIn/InstallerResources/install.py View 2 chunks +14 lines, -4 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
6 years, 10 months ago (2014-02-03 21:34:52 UTC) #1
binji
lgtm https://codereview.chromium.org/153163002/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/install.py File visual_studio/NativeClientVSAddIn/InstallerResources/install.py (right): https://codereview.chromium.org/153163002/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/install.py#newcode119 visual_studio/NativeClientVSAddIn/InstallerResources/install.py:119: if not os.path.exists(platform_root): This is superfluous now, right?
6 years, 10 months ago (2014-02-03 21:46:41 UTC) #2
Sam Clegg
https://codereview.chromium.org/153163002/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/install.py File visual_studio/NativeClientVSAddIn/InstallerResources/install.py (right): https://codereview.chromium.org/153163002/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/install.py#newcode119 visual_studio/NativeClientVSAddIn/InstallerResources/install.py:119: if not os.path.exists(platform_root): On 2014/02/03 21:46:41, binji wrote: > ...
6 years, 10 months ago (2014-02-03 22:44:54 UTC) #3
Sam Clegg
6 years, 10 months ago (2014-02-04 18:30:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r1570 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698