Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: pydir/run-pnacl-sz.py

Issue 1531623007: Add option to force filetype=asm for testing (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Formatting Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pydir/run-pnacl-sz.py
diff --git a/pydir/run-pnacl-sz.py b/pydir/run-pnacl-sz.py
index b7434adc25de0c02c4143e390e16d50ded727bf1..c386f73875d6f6c99fe8b29ca67169933c5b213c 100755
--- a/pydir/run-pnacl-sz.py
+++ b/pydir/run-pnacl-sz.py
@@ -78,6 +78,8 @@ def main():
argparser.add_argument('--filetype', default='iasm', dest='filetype',
choices=['obj', 'asm', 'iasm'],
help='Output file type. Default %(default)s.')
+ argparser.add_argument('--forceasm', required=False, action='store_true',
+ help='Force --filetype=asm.')
Jim Stichnoth 2015/12/20 18:42:23 OCD: Remove the '.' from the help string for consi
sehr 2016/01/07 18:53:11 Done.
argparser.add_argument('--target', default='x8632', dest='target',
choices=['x8632','arm32','mips32'],
help='Target architecture. Default %(default)s.')
@@ -111,6 +113,16 @@ def main():
if args.llvm and args.tbc:
raise RuntimeError("Can't specify both '--tbc' and '--llvm'")
+ if args.forceasm:
+ if args.filetype == 'asm':
+ pass
+ elif args.filetype == 'iasm':
+ # TODO(sehr) implement forceasm for iasm.
+ pass
+ elif args.filetype == 'obj':
+ args.filetype = 'asm'
+ args.assemble = True
+
cmd = []
if args.tbc:
cmd = [os.path.join(pnacl_bin_path, 'pnacl-bcfuzz'), llfile,

Powered by Google App Engine
This is Rietveld 408576698