Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tests_lit/assembler/x86/jump_encodings.ll

Issue 1531623007: Add option to force filetype=asm for testing (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Missed one --sandbox in the wrong place. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests_lit/assembler/x86/jump_encodings.ll
diff --git a/tests_lit/assembler/x86/jump_encodings.ll b/tests_lit/assembler/x86/jump_encodings.ll
index e2f0e3b7e591960fbb4c93cc45dab8187199c5fa..e7d444e0c0b5f6229400ebcc42182fa13f000df6 100644
--- a/tests_lit/assembler/x86/jump_encodings.ll
+++ b/tests_lit/assembler/x86/jump_encodings.ll
@@ -140,15 +140,16 @@ next3:
call void @llvm.nacl.atomic.store.i32(i32 %val, i32* %ptr, i32 6)
br label %next1
}
-; Forward branches for non-local labels currently use the fully relaxed
-; form to avoid needing a relaxation pass.
+; Note: forward branches for non-local labels in Subzero currently use the fully
+; relaxed form (4-byte offset) to avoid needing a relaxation pass. When we use
+; llvm-mc, it performs the relaxation pass and uses a 1-byte offset.
; CHECK-LABEL: test_near_forward
-; CHECK: 8: {{.*}} cmp
-; CHECK-NEXT: b: 0f 82 05 00 00 00 jb 16
-; CHECK-NEXT: 11: {{.*}} mov DWORD PTR
-; CHECK-NEXT: 13: {{.*}} mfence
-; CHECK-NEXT: 16: {{.*}} mov DWORD PTR
-; CHECK: 1b: eb eb jmp 8
+; CHECK: [[BACKLABEL:[0-9a-f]+]]: {{.*}} cmp
+; CHECK-NEXT: {{.*}} jb [[FORWARDLABEL:[0-9a-f]+]]
+; CHECK-NEXT: {{.*}} mov DWORD PTR
+; CHECK-NEXT: {{.*}} mfence
+; CHECK-NEXT: [[FORWARDLABEL]]: {{.*}} mov DWORD PTR
+; CHECK: {{.*}} jmp [[BACKLABEL]]
; Unlike forward branches to cfg nodes, "local" forward branches

Powered by Google App Engine
This is Rietveld 408576698