Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1531613002: Fix for recording static elements of a prefixed comment reference. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for recording static elements of a prefixed comment reference. I notied during reading idl.dart that I'd like to see highlighting and search for type names in comment references like [PrelinkedLibrary.dependencies]. With this change we get highlighting, search and refactoring for both. Navigation also works (*). (*) does not work in IntelliJ - it does not parse Dart comments for reference expressions. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ea922ef7f4f79c68fd52684c96a5c2b16289e228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/element_resolver.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-16 04:49:13 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-16 14:13:20 UTC) #2
scheglov
5 years ago (2015-12-16 17:03:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ea922ef7f4f79c68fd52684c96a5c2b16289e228 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698