Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 1531583004: [DevTools] Improve Device Mode icons. (Closed)

Created:
5 years ago by dgozman
Modified:
5 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@toolbar-refactor
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Improve Device Mode icons. BUG=540864 Committed: https://crrev.com/1b6c421840399992b758241159f32fad6f94ea40 Cr-Commit-Position: refs/heads/master@{#365999}

Patch Set 1 #

Patch Set 2 : test #

Messages

Total messages: 13 (6 generated)
dgozman
Take a look please.
5 years ago (2015-12-17 02:51:09 UTC) #2
pfeldman
lgtm
5 years ago (2015-12-17 20:25:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531583004/1
5 years ago (2015-12-17 20:41:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/94262) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-12-17 21:36:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531583004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531583004/20001
5 years ago (2015-12-18 01:46:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-18 03:01:14 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-18 03:01:56 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b6c421840399992b758241159f32fad6f94ea40
Cr-Commit-Position: refs/heads/master@{#365999}

Powered by Google App Engine
This is Rietveld 408576698