infra_libs/ts_mon/common/errors.py - Issue 1531573003: Handle multiple modifications to distribution metrics correctly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra_libs/ts_mon/common/errors.py

Issue 1531573003: Handle multiple modifications to distribution metrics correctly. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Add a missing test for coverage Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: infra_libs/ts_mon/common/errors.py

diff --git a/infra_libs/ts_mon/common/errors.py b/infra_libs/ts_mon/common/errors.py

index 5698e31fd9e0971a989e40535273f73436912e5b..29f3cd1f71e21cae7bdf2271f844d6199d7b61a4 100644

--- a/infra_libs/ts_mon/common/errors.py

+++ b/infra_libs/ts_mon/common/errors.py

@@ -13,7 +13,7 @@ class MonitoringDecreasingValueError(MonitoringError):

"""Raised when setting a metric value that should increase but doesn't."""

def __init__(self, metric, old_value, new_value):

- self.metric = metric,

+ self.metric = metric

self.old_value = old_value

self.new_value = new_value

« no previous file with comments | « appengine_module/gae_ts_mon/test/memcache_metric_store_test.py ('k') | infra_libs/ts_mon/common/metric_store.py » ('j') | no next file with comments »