Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2477)

Unified Diff: appengine_module/gae_ts_mon/test/deferred_metric_store_test.py

Issue 1531573003: Handle multiple modifications to distribution metrics correctly. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Add a missing test for coverage Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine_module/gae_ts_mon/test/deferred_metric_store_test.py
diff --git a/appengine_module/gae_ts_mon/test/deferred_metric_store_test.py b/appengine_module/gae_ts_mon/test/deferred_metric_store_test.py
index 84fac8279080e460be23f7d5d78b0a1c780de764..aba66937d4b15a2f9e67d972b7e92c1913cc711d 100644
--- a/appengine_module/gae_ts_mon/test/deferred_metric_store_test.py
+++ b/appengine_module/gae_ts_mon/test/deferred_metric_store_test.py
@@ -116,11 +116,11 @@ class DeferredMetricStoreTest(metric_store_test.MetricStoreTestBase,
def test_deferred_set_then_set(self):
self.store.initialize_context()
- self.counter_metric.set(42)
self.counter_metric.set(12)
+ self.counter_metric.set(42)
self.store.finalize_context()
- self.assertEquals(12, self.counter_metric.get())
+ self.assertEquals(42, self.counter_metric.get())
def test_deferred_set_with_fields(self):
self.store.initialize_context()
@@ -144,4 +144,7 @@ class DeferredMetricStoreTest(metric_store_test.MetricStoreTestBase,
self.cumulative_dist_metric.add(1)
self.store.finalize_context()
- self.assertEquals(5, self.cumulative_dist_metric.get().sum)
+ dist = self.cumulative_dist_metric.get()
+ self.assertEquals(5, dist.sum)
+ self.assertEquals(2, dist.count)
+ self.assertEquals([2, 5], sorted(dist.buckets.keys()))
« no previous file with comments | « appengine_module/gae_ts_mon/memcache_metric_store.py ('k') | appengine_module/gae_ts_mon/test/memcache_metric_store_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698