Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: infra_libs/ts_mon/common/test/metric_store_test.py

Issue 1531573003: Handle multiple modifications to distribution metrics correctly. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra_libs/ts_mon/common/test/metric_store_test.py
diff --git a/infra_libs/ts_mon/common/test/metric_store_test.py b/infra_libs/ts_mon/common/test/metric_store_test.py
index bb38f715b29cbb7905e747bf7bee53bcff708342..6b8cb579e5989f1ca8f39b5b1e93b175a7767721 100644
--- a/infra_libs/ts_mon/common/test/metric_store_test.py
+++ b/infra_libs/ts_mon/common/test/metric_store_test.py
@@ -133,53 +133,3 @@ class MetricStoreTestBase(object):
class InProcessMetricStoreTest(MetricStoreTestBase, unittest.TestCase):
METRIC_STORE_CLASS = metric_store.InProcessMetricStore
-
-
-class CombineModificationsTest(unittest.TestCase):
- def test_set_set(self):
- self.assertEqual(
- metric_store.Modification('two', (), 'set', (2, False)),
- metric_store.combine_modifications(
- metric_store.Modification('one', (), 'set', (1, False)),
- metric_store.Modification('two', (), 'set', (2, False))))
-
- def test_set_incr(self):
- self.assertEqual(
- metric_store.Modification('one', (), 'set', (3, False)),
- metric_store.combine_modifications(
- metric_store.Modification('one', (), 'set', (1, False)),
- metric_store.Modification('two', (), 'incr', (2, operator.add))))
-
- def test_incr_set(self):
- self.assertEqual(
- metric_store.Modification('two', (), 'set', (2, False)),
- metric_store.combine_modifications(
- metric_store.Modification('one', (), 'incr', (1, operator.add)),
- metric_store.Modification('two', (), 'set', (2, False))))
-
- def test_incr_incr(self):
- self.assertEqual(
- metric_store.Modification('one', (), 'incr', (3, operator.add)),
- metric_store.combine_modifications(
- metric_store.Modification('one', (), 'incr', (1, operator.add)),
- metric_store.Modification('two', (), 'incr', (2, operator.add))))
-
- def test_none_set(self):
- self.assertEqual(
- metric_store.Modification('two', (), 'set', (2, False)),
- metric_store.combine_modifications(
- None,
- metric_store.Modification('two', (), 'set', (2, False))))
-
- def test_none_incr(self):
- self.assertEqual(
- metric_store.Modification('two', (), 'incr', (2, operator.add)),
- metric_store.combine_modifications(
- None,
- metric_store.Modification('two', (), 'incr', (2, operator.add))))
-
- def test_bad_type(self):
- with self.assertRaises(errors.UnknownModificationTypeError):
- metric_store.combine_modifications(
- metric_store.Modification('one', (), 'set', (1, False)),
- metric_store.Modification('two', (), 'bad', (2, False)))

Powered by Google App Engine
This is Rietveld 408576698