net/quic/congestion_control/tcp_cubic_bytes_sender.cc - Issue 1531543004: Fix a bug protected by gfe2_reloadable_flag_quic_respect_send_alarm where acks would not be sent im…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/congestion_control/tcp_cubic_bytes_sender.cc

Issue 1531543004: Fix a bug protected by gfe2_reloadable_flag_quic_respect_send_alarm where acks would not be sent im… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@110021608

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/congestion_control/tcp_cubic_bytes_sender.cc

diff --git a/net/quic/congestion_control/tcp_cubic_bytes_sender.cc b/net/quic/congestion_control/tcp_cubic_bytes_sender.cc

index e2d9519de34ad474baa3c9e0c68b06102eb1e867..078e3d4106b0a3c6f0c304ba23b96b659c85810f 100644

--- a/net/quic/congestion_control/tcp_cubic_bytes_sender.cc

+++ b/net/quic/congestion_control/tcp_cubic_bytes_sender.cc

@@ -218,6 +218,7 @@ QuicTime::Delta TcpCubicBytesSender::TimeUntilSend(

QuicByteCount bytes_in_flight,

HasRetransmittableData has_retransmittable_data) const {

if (has_retransmittable_data == NO_RETRANSMITTABLE_DATA) {

+ DCHECK(!FLAGS_quic_respect_send_alarm2);

// For TCP we can always send an ACK immediately.

return QuicTime::Delta::Zero();

}

« no previous file with comments | « no previous file | net/quic/congestion_control/tcp_cubic_sender.cc » ('j') | no next file with comments »