Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7016)

Unified Diff: chromecast/base/cast_resource.h

Issue 1531543002: [Chromecast] Adding pause/resume operations to VideoPlaneController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Just modified a comment back the way it was. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/base/cast_resource.h
diff --git a/chromecast/base/cast_resource.h b/chromecast/base/cast_resource.h
index cd248d77edc26872e426c5c2a42ef54a2aac1e0a..84c92f4423d16ec2bd3c2dcaf449e87d51114119 100644
--- a/chromecast/base/cast_resource.h
+++ b/chromecast/base/cast_resource.h
@@ -53,6 +53,14 @@ class CastResource {
};
void SetCastResourceClient(Client* client);
+ // Called to initialize resources after OEM has granted them, and before
+ // they start getting used by consumers. Implementation must be synchronous
+ // since consumers will start using the resource immediately afterwards.
+ // TODO(esum): We should allow this method to be asynchronous in case an
+ // implementer needs to make expensive calls and doesn't want to block the
+ // UI thread (b/26239576). For now, don't do anything expensive in your
+ // implementation; if you really need to, then this bug has to be resolved.
+ virtual void InitializeResource(Resource resource) = 0;
byungchul 2015/12/18 00:53:21 GrantResource?
esum 2015/12/21 00:39:21 I actually prefer InitializeResource since this se
derekjchow1 2016/01/04 17:29:10 How about AcquireResource, since this is the oppos
esum 2016/01/11 16:28:57 Done. Had to rearrange some names to make things c
// Called to release resources. Implementation should call
// Client::OnResourceReleased when resource is released on its side.
virtual void ReleaseResource(Resource resource) = 0;

Powered by Google App Engine
This is Rietveld 408576698