[Chromecast] Adding pause/resume operations to VideoPlaneController.

chromecast/base/cast_resource.h

Index: chromecast/base/cast_resource.h
diff --git a/chromecast/base/cast_resource.h b/chromecast/base/cast_resource.h
index cd248d77edc26872e426c5c2a42ef54a2aac1e0a..b0245b26b06311d204fd0a7e82489ff1cd62f0ad 100644
--- a/chromecast/base/cast_resource.h
+++ b/chromecast/base/cast_resource.h
@@ -53,6 +53,10 @@ class CastResource {
   };
 
   void SetCastResourceClient(Client* client);
+  // Called to initialize resources after OEM has granted them, and before
+  // they start getting used by consumers. Implementation must be synchronous
+  // since consumers will start using the resource immediately afterwards.
+  virtual void InitializeResource(Resource resource) = 0;

[derekjchow1, 2015/12/15 22:40:35]

What thread does this get called on? If this gets called on the UI thread we
should make this API asynchronous in case if initialization becomes a long
operation.

Also another reason to make this asynchronous would be to mirror
ReleaseResource().

[yucliu1, 2015/12/15 23:05:58]

Probably we can make a contract here: InitializeResource should have a
corresponding Client::OnResourceAcquired. This requires add other two APIs to
add/remove CastResource to/from watch list.

Otherwise, this function may not be called, right? Can you add comments here?

[esum, 2015/12/17 08:28:12]

Agreed it should be made asynchronous, but I would really like to tackle this
after 1.18 in the interest of fixing the actual bug at hand for OEM's soon.
Especially because this is not sounding like a straightforward change. I think
Tavis has some thoughts on this also.

Is there a problem with the way the code is now? I know it's not ideal, but it's
simple and all the VideoPlane calls are very quick.

Also Luke/Gaofeng, what do you think?

[halliwell, 2015/12/17 14:46:31]

Calling VideoPlane synchronously is fine.  I'm ok with following up on async API
afterwards.

   // Called to release resources. Implementation should call
   // Client::OnResourceReleased when resource is released on its side.
   virtual void ReleaseResource(Resource resource) = 0;