Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153153002: [chromeos] Move files from chromeos/power to chrome/browser/chromeos/power (Closed)

Created:
6 years, 10 months ago by Siva Chandra
Modified:
6 years, 10 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, derat+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

[chromeos] Move files from chromeos/power to chrome/browser/chromeos/power This is being done so that content::BrowserThread can be used in PowerDataCollector, which is required for future changes. BUG=312956, 335816 TBR=arv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -295 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/power/power_data_collector.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/power/power_data_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/power/power_data_collector_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/power_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
D chromeos/power/power_data_collector.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chromeos/power/power_data_collector.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D chromeos/power/power_data_collector_unittest.cc View 1 chunk +0 lines, -88 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Siva Chandra
6 years, 10 months ago (2014-02-03 23:16:46 UTC) #1
Daniel Erat
lgtm
6 years, 10 months ago (2014-02-03 23:38:29 UTC) #2
Siva Chandra
The CQ bit was checked by sivachandra@chromium.org
6 years, 10 months ago (2014-02-03 23:48:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/153153002/1
6 years, 10 months ago (2014-02-03 23:51:54 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 02:20:28 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=255954
6 years, 10 months ago (2014-02-04 02:20:28 UTC) #6
Siva Chandra
The CQ bit was checked by sivachandra@chromium.org
6 years, 10 months ago (2014-02-04 10:21:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/153153002/1
6 years, 10 months ago (2014-02-04 10:21:24 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 16:48:18 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=256476
6 years, 10 months ago (2014-02-04 16:48:18 UTC) #10
Siva Chandra
The CQ bit was checked by sivachandra@chromium.org
6 years, 10 months ago (2014-02-04 17:38:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/153153002/1
6 years, 10 months ago (2014-02-04 17:41:38 UTC) #12
Siva Chandra
The CQ bit was unchecked by sivachandra@chromium.org
6 years, 10 months ago (2014-02-04 22:30:51 UTC) #13
Siva Chandra
The CQ bit was checked by sivachandra@chromium.org
6 years, 10 months ago (2014-02-04 22:31:07 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 22:51:06 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=256814
6 years, 10 months ago (2014-02-04 22:51:07 UTC) #16
Siva Chandra
The CQ bit was checked by sivachandra@chromium.org
6 years, 10 months ago (2014-02-04 22:56:41 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/153153002/1
6 years, 10 months ago (2014-02-04 23:13:59 UTC) #18
Siva Chandra
The CQ bit was unchecked by sivachandra@chromium.org
6 years, 10 months ago (2014-02-05 00:17:17 UTC) #19
Siva Chandra
The CQ bit was checked by sivachandra@chromium.org
6 years, 10 months ago (2014-02-05 00:23:14 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sivachandra@chromium.org/153153002/1
6 years, 10 months ago (2014-02-05 01:27:01 UTC) #21
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 04:53:56 UTC) #22
Message was sent while issue was closed. 
Change committed as 248852

Powered by Google App Engine
This is Rietveld 408576698