Generate unique certificate nicknames on Linux/CrOS.

net/third_party/mozilla_security_manager/nsNSSCertificateDB.cpp

  /* ***** BEGIN LICENSE BLOCK *****
  * Version: MPL 1.1/GPL 2.0/LGPL 2.1
  *
  * The contents of this file are subject to the Mozilla Public License Version
  * 1.1 (the "License"); you may not use this file except in compliance with
  * the License. You may obtain a copy of the License at
  * http://www.mozilla.org/MPL/
  *
  * Software distributed under the License is distributed on an "AS IS" basis,
  * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
@@ skipping 30 matching lines @@
 #include <cert.h>
 #include <certdb.h>
 #include <pk11pub.h>
 #include <secerr.h>
 
 #include "base/logging.h"
 #include "crypto/nss_util_internal.h"
 #include "crypto/scoped_nss_types.h"
 #include "net/base/net_errors.h"
 #include "net/cert/x509_certificate.h"
+#include "net/cert/x509_util_nss.h"
 
 #if !defined(CERTDB_TERMINAL_RECORD)
 /* NSS 3.13 renames CERTDB_VALID_PEER to CERTDB_TERMINAL_RECORD
  * and marks CERTDB_VALID_PEER as deprecated.
  * If we're using an older version, rename it ourselves.
  */
 #define CERTDB_TERMINAL_RECORD CERTDB_VALID_PEER
 #endif
 
 namespace mozilla_security_manager {
@@ skipping 27 matching lines @@
     not_imported->push_back(net::NSSCertDatabase::ImportCertFailure(
         root, net::ERR_IMPORT_CERT_ALREADY_EXISTS));
   } else {
     // Mozilla uses CERT_AddTempCertToPerm, however it is privately exported,
     // and it doesn't take the slot as an argument either.  Instead, we use
     // PK11_ImportCert and CERT_ChangeCertTrust.
     SECStatus srv = PK11_ImportCert(
         slot.get(),
         root->os_cert_handle(),
         CK_INVALID_HANDLE,
-        root->GetDefaultNickname(net::CA_CERT).c_str(),
+        net::x509_util::GetUniqueNicknameForSlot(
+            root->GetDefaultNickname(net::CA_CERT),
+            &root->os_cert_handle()->derSubject,
+            slot.get()).c_str(),
         PR_FALSE /* includeTrust (unused) */);
     if (srv != SECSuccess) {
       LOG(ERROR) << "PK11_ImportCert failed with error " << PORT_GetError();
       return false;
     }
     if (!SetCertTrust(root, net::CA_CERT, trustBits))
       return false;
   }
 
   PRTime now = PR_Now();
@@ skipping 36 matching lines @@
       VLOG(1) << "skipping cert (verify) " << PORT_GetError();
       continue;
     }
 
     // Mozilla uses CERT_ImportCerts, which doesn't take a slot arg.  We use
     // PK11_ImportCert instead.
     SECStatus srv = PK11_ImportCert(
         slot.get(),
         cert->os_cert_handle(),
         CK_INVALID_HANDLE,
-        cert->GetDefaultNickname(net::CA_CERT).c_str(),
+        net::x509_util::GetUniqueNicknameForSlot(
+            cert->GetDefaultNickname(net::CA_CERT),
+            &cert->os_cert_handle()->derSubject,
+            slot.get()).c_str(),
         PR_FALSE /* includeTrust (unused) */);
     if (srv != SECSuccess) {
       LOG(ERROR) << "PK11_ImportCert failed with error " << PORT_GetError();
       // TODO(mattm): Should we bail or continue on error here?  Mozilla doesn't
       // check error code at all.
       not_imported->push_back(net::NSSCertDatabase::ImportCertFailure(
           cert, net::ERR_IMPORT_CA_CERT_FAILED));
     }
   }
 
@@ skipping 17 matching lines @@
 
   for (size_t i = 0; i < certificates.size(); ++i) {
     const scoped_refptr<net::X509Certificate>& cert = certificates[i];
 
     // Mozilla uses CERT_ImportCerts, which doesn't take a slot arg.  We use
     // PK11_ImportCert instead.
     SECStatus srv = PK11_ImportCert(
         slot.get(),
         cert->os_cert_handle(),
         CK_INVALID_HANDLE,
-        cert->GetDefaultNickname(net::SERVER_CERT).c_str(),
+        net::x509_util::GetUniqueNicknameForSlot(
+            cert->GetDefaultNickname(net::SERVER_CERT),
+            &cert->os_cert_handle()->derSubject,
+            slot.get()).c_str(),
         PR_FALSE /* includeTrust (unused) */);
     if (srv != SECSuccess) {
       LOG(ERROR) << "PK11_ImportCert failed with error " << PORT_GetError();
       not_imported->push_back(net::NSSCertDatabase::ImportCertFailure(
           cert, net::ERR_IMPORT_SERVER_CERT_FAILED));
       continue;
     }
   }
 
   SetCertTrust(certificates[0].get(), net::SERVER_CERT, trustBits);
@@ skipping 64 matching lines @@
   } else {
     // ignore user and email/unknown certs
     return true;
   }
   if (srv != SECSuccess)
     LOG(ERROR) << "SetCertTrust failed with error " << PORT_GetError();
   return srv == SECSuccess;
 }
 
 }  // namespace mozilla_security_manager