Avoid pixel GPU readback in saveLayerWithPickup

Avoid pixel GPU readback in saveLayerWithPickup

When the default framebuffer is wrapped in a device for rendering we don't get a GrTexture. This CL adds a copy to a temporary texture in this instance so the rest of the Ganesh pipeline can continue on as usual.

Committed: https://skia.googlesource.com/skia/+/7354a4b193aaaeae43fb9ede90e1158fa46c372b
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1531493002

[robertphillips, 2015-12-15 19:58:04]

Description was changed from

==========
Avoid pixel GPU readback in saveLayerWithPickup
==========

to

==========
Avoid pixel GPU readback in saveLayerWithPickup

When the default framebuffer is wrapped in a device for rendering we don't get a
GrTexture. This CL adds a copy to a temporary texture in this instance so the
rest of the Ganesh pipeline can continue.
==========

[robertphillips, 2015-12-15 19:58:05]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[robertphillips, 2015-12-15 19:58:27]

Description was changed from

==========
Avoid pixel GPU readback in saveLayerWithPickup

When the default framebuffer is wrapped in a device for rendering we don't get a
GrTexture. This CL adds a copy to a temporary texture in this instance so the
rest of the Ganesh pipeline can continue.
==========

to

==========
Avoid pixel GPU readback in saveLayerWithPickup

When the default framebuffer is wrapped in a device for rendering we don't get a
GrTexture. This CL adds a copy to a temporary texture in this instance so the
rest of the Ganesh pipeline can continue on as usual.
==========

[bsalomon, 2015-12-15 20:03:48]

https://codereview.chromium.org/1531493002/diff/40001/src/gpu/gl/GrGLDefines.h
File src/gpu/gl/GrGLDefines.h (right):

https://codereview.chromium.org/1531493002/diff/40001/src/gpu/gl/GrGLDefines....
src/gpu/gl/GrGLDefines.h:823: #define GR_GL_FRAMEBUFFER_DEFAULT           
0x8218
what's this for?

https://codereview.chromium.org/1531493002/diff/40001/src/gpu/gl/GrGLUtil.h
File src/gpu/gl/GrGLUtil.h (right):

https://codereview.chromium.org/1531493002/diff/40001/src/gpu/gl/GrGLUtil.h#n...
src/gpu/gl/GrGLUtil.h:84: #define
GR_GL_GetNamedFramebufferAttachmentParameteriv(gl, fb, a, pname, p)          \
and this?

[robertphillips, 2015-12-15 20:13:24]

https://codereview.chromium.org/1531493002/diff/40001/src/gpu/gl/GrGLDefines.h
File src/gpu/gl/GrGLDefines.h (right):

https://codereview.chromium.org/1531493002/diff/40001/src/gpu/gl/GrGLDefines....
src/gpu/gl/GrGLDefines.h:823: #define GR_GL_FRAMEBUFFER_DEFAULT           
0x8218
On 2015/12/15 20:03:47, bsalomon wrote:
> what's this for?

Initially I was experimenting with what information I could get out of the
default frame buffer. This is what what
glGetNamedFramebufferAttachmentParameteriv returns as the
GL_FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE when the default frame buffer is queried.
It isn't crucial to the current CL but I thought it might be nice to have around
(we already have the 3 other possible values).

https://codereview.chromium.org/1531493002/diff/40001/src/gpu/gl/GrGLUtil.h
File src/gpu/gl/GrGLUtil.h (right):

https://codereview.chromium.org/1531493002/diff/40001/src/gpu/gl/GrGLUtil.h#n...
src/gpu/gl/GrGLUtil.h:84: #define
GR_GL_GetNamedFramebufferAttachmentParameteriv(gl, fb, a, pname, p)          \
On 2015/12/15 20:03:47, bsalomon wrote:
> and this?

Same as the other one (GR_GL_FRAMEBUFFER_DEFAULT). Not necessary but it might be
nice to have around (if we ever want to actually call
GetNamedFramebufferAttachmentParameteriv).

[bsalomon, 2015-12-15 20:16:12]

lgtm

[robertphillips, 2015-12-15 20:17:51]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-15 20:17:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531493002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531493002/40001

[commit-bot: I haz the power, 2015-12-15 20:18:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 20:18:51]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[robertphillips, 2015-12-15 20:22:26]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-15 20:22:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531493002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531493002/60001

[commit-bot: I haz the power, 2015-12-15 20:37:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 20:37:27]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-12-16 13:07:43]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2015-12-16 13:07:43]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1531493002/#ps60001
(title: "Quiet compiler complaints")

[commit-bot: I haz the power, 2015-12-16 13:07:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531493002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531493002/60001

[commit-bot: I haz the power, 2015-12-16 13:08:32]

Description was changed from

==========
Avoid pixel GPU readback in saveLayerWithPickup

When the default framebuffer is wrapped in a device for rendering we don't get a
GrTexture. This CL adds a copy to a temporary texture in this instance so the
rest of the Ganesh pipeline can continue on as usual.
==========

to

==========
Avoid pixel GPU readback in saveLayerWithPickup

When the default framebuffer is wrapped in a device for rendering we don't get a
GrTexture. This CL adds a copy to a temporary texture in this instance so the
rest of the Ganesh pipeline can continue on as usual.

Committed:
https://skia.googlesource.com/skia/+/7354a4b193aaaeae43fb9ede90e1158fa46c372b
==========

[commit-bot: I haz the power, 2015-12-16 13:08:32]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/7354a4b193aaaeae43fb9ede90e1158fa46c372b

[robertphillips, 2016-01-07 17:39:46]

Description was changed from

==========
Avoid pixel GPU readback in saveLayerWithPickup

When the default framebuffer is wrapped in a device for rendering we don't get a
GrTexture. This CL adds a copy to a temporary texture in this instance so the
rest of the Ganesh pipeline can continue on as usual.

Committed:
https://skia.googlesource.com/skia/+/7354a4b193aaaeae43fb9ede90e1158fa46c372b
==========

to

==========
Avoid pixel GPU readback in saveLayerWithPickup

When the default framebuffer is wrapped in a device for rendering we don't get a
GrTexture. This CL adds a copy to a temporary texture in this instance so the
rest of the Ganesh pipeline can continue on as usual.

Committed:
https://skia.googlesource.com/skia/+/7354a4b193aaaeae43fb9ede90e1158fa46c372b
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-01-07 17:40:13]

Patchset #5 (id:80001) has been deleted