Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2884)

Unified Diff: pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart

Issue 1531473006: move functional argument check into manager (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart
diff --git a/pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart b/pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart
index e51dd001cd182053ed477a2a6cda62fc745ab8db..c04ce43eb36cb02ebc3a1a746f9d1571126de432 100644
--- a/pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart
+++ b/pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart
@@ -265,6 +265,7 @@ class CompletionTarget {
/**
* Return `true` if the target is a functional argument in an argument list.
* The target [AstNode] hierarchy *must* be resolved for this to work.
+ * See [maybeFunctionalArgument].
*/
bool isFunctionalArgument() {
if (!maybeFunctionalArgument()) {
@@ -299,8 +300,9 @@ class CompletionTarget {
}
/**
- * Return `true` if the target is a functional argument in an argument list.
- * The target [AstNode] hierarchy *must* be resolved for this to work.
+ * Return `true` if the target maybe a functional argument in an argument list.
+ * This is used in determining whether the target [AstNode] hierarchy
+ * needs to be resolved so that [isFunctionalArgument] will work.
*/
bool maybeFunctionalArgument() {
if (argIndex == null) {
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698