third_party/WebKit/Source/web/tests/data/composited_selection_bounds_vertical_lr.html - Issue 1531473004: Fix selection handles in vertical writing modes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/data/composited_selection_bounds_vertical_lr.html

Issue 1531473004: Fix selection handles in vertical writing modes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Apply code review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | third_party/WebKit/Source/web/tests/data/composited_selection_bounds_vertical_rl.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/data/composited_selection_bounds_vertical_lr.html

diff --git a/third_party/WebKit/Source/web/tests/data/composited_selection_bounds_basic.html b/third_party/WebKit/Source/web/tests/data/composited_selection_bounds_vertical_lr.html

similarity index 76%

copy from third_party/WebKit/Source/web/tests/data/composited_selection_bounds_basic.html

copy to third_party/WebKit/Source/web/tests/data/composited_selection_bounds_vertical_lr.html

index 962418581e36ae592045e802c0453b07ec632c27..b842fea8dfd190c9fbb3ea63dea799ce5709ad08 100644

--- a/third_party/WebKit/Source/web/tests/data/composited_selection_bounds_basic.html

+++ b/third_party/WebKit/Source/web/tests/data/composited_selection_bounds_vertical_lr.html

@@ -6,6 +6,9 @@

* {

font-family: ahem;

}

+ body {

+ -webkit-writing-mode: vertical-lr;

+ }

</style>

The quick brown fox jumped over the lazy dog.

@@ -17,6 +20,6 @@

range.setEnd(textNode, 25);

document.getSelection().addRange(range);

- window.expectedResult = [document, 68, 8, 68, 20, document, 248, 8, 248, 20];

+ window.expectedResult = [document, 20, 68, 8, 68, document, 8, 248, 20, 248];

</script>