Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1531453004: Indexer one-shot fast path adjustment (Closed)

Created:
5 years ago by sra1
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Indexer one-shot fast path adjustment If the index/key is not a number it is unlikely that the receiver is an Array-like JavaScript object. This suggests that we should have a version of the one-shot with no fast-path to use at call sites where we can prove the (receiver, argument) combination does not benefit from the fast path. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/042fcc9de0df8c196eac43eeb62b5053e2012f0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 3 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
5 years ago (2015-12-16 22:45:23 UTC) #3
Siggi Cherem (dart-lang)
lgtm!
5 years ago (2015-12-16 22:53:12 UTC) #4
sra1
5 years ago (2015-12-16 23:07:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
042fcc9de0df8c196eac43eeb62b5053e2012f0f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698