Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 1531453003: [turbofan] Removed "auto". (Closed)

Created:
5 years ago by Mircea Trofin
Modified:
5 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Removed "auto". ...except for 2 places (map::insert and map::find returns) [turbofan] move down parallel moves BUG= Committed: https://crrev.com/e3f0b5a4f0e2ca7ff7696e1c3b5bcb70294a8e7b Cr-Commit-Position: refs/heads/master@{#32875}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fixed merge conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -34 lines) Patch
M src/compiler/move-optimizer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/move-optimizer.cc View 1 2 12 chunks +35 lines, -33 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Mircea Trofin
Opportunistically removed "auto" in move-optimizer.cc, since I'm working there for a bit.
5 years ago (2015-12-16 00:37:23 UTC) #3
Benedikt Meurer
Nice cleanup. LGTM.
5 years ago (2015-12-16 04:51:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531453003/20001
5 years ago (2015-12-16 04:55:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/11431)
5 years ago (2015-12-16 05:04:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531453003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531453003/40001
5 years ago (2015-12-16 05:10:32 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-16 05:53:23 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-16 05:54:19 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e3f0b5a4f0e2ca7ff7696e1c3b5bcb70294a8e7b
Cr-Commit-Position: refs/heads/master@{#32875}

Powered by Google App Engine
This is Rietveld 408576698