Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl

Issue 1531443003: [bindings] Implement an ExperimentEnabled IDL extended attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments. Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl
diff --git a/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl b/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl
index ec0fe4e21ffee7a47b9734e9d444408739094872..20df18b5d8cfb0d6266a024a6a5d09410e688bd2 100644
--- a/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl
+++ b/third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl
@@ -67,6 +67,11 @@ interface TestObject {
[RuntimeEnabled=FeatureName2] const short FEATURE2_ENABLED_CONST1 = 3;
[RuntimeEnabled=FeatureName2] const short FEATURE2_ENABLED_CONST2 = 4;
[RuntimeEnabled=FeatureName3] const short FEATURE3_ENABLED_CONST1 = 5;
+ [RuntimeEnabled=FeatureName1, APIExperimentEnabled=FeatureName1] const short FEATURE1_RUNTIME_AND_EXPERIMENT_ENABLED_CONST1 = 1;
+ [RuntimeEnabled=FeatureName1, APIExperimentEnabled=FeatureName1] const short FEATURE1_RUNTIME_AND_EXPERIMENT_ENABLED_CONST2 = 2;
+ [RuntimeEnabled=FeatureName2, APIExperimentEnabled=FeatureName2] const short FEATURE2_RUNTIME_AND_EXPERIMENT_ENABLED_CONST1 = 3;
+ [RuntimeEnabled=FeatureName2, APIExperimentEnabled=FeatureName2] const short FEATURE2_RUNTIME_AND_EXPERIMENT_ENABLED_CONST2 = 4;
+ [RuntimeEnabled=FeatureName3, APIExperimentEnabled=FeatureName3] const short FEATURE3_RUNTIME_AND_EXPERIMENT_ENABLED_CONST1 = 5;
[Reflect=CONST_IMPL] const short CONST_JAVASCRIPT = 1;
stringifier attribute DOMString stringifierAttribute;
@@ -191,6 +196,8 @@ interface TestObject {
[CustomElementCallbacks] readonly attribute long customElementsCallbacksReadonlyLongAttribute;
[DeprecateAs=LongAttribute] attribute long deprecatedLongAttribute;
[EnforceRange] attribute long enforceRangeLongAttribute;
+ [APIExperimentEnabled=FeatureName, RuntimeEnabled=FeatureName] attribute long experimentRuntimeEnabledLongAttribute;
+ [APIExperimentEnabled=FeatureName, Conditional=CONDITION, RuntimeEnabled=FeatureName] attribute long experimentConditionalRuntimeEnabledLongAttribute;
[ImplementedAs=implementedAsName] attribute long implementedAsLongAttribute;
[Custom, ImplementedAs=implementedAsNameWithCustom] attribute long customImplementedAsLongAttribute;
[Custom=Getter, ImplementedAs=implementedAsNameWithCustomGetter] attribute long customGetterImplementedAsLongAttribute;
@@ -263,6 +270,7 @@ interface TestObject {
[Measure] attribute long measuredLongAttribute;
[SameObject] attribute TestInterface sameObjectAttribute;
[Unscopeable] attribute long unscopeableLongAttribute;
+ [Unscopeable, APIExperimentEnabled=FeatureName, RuntimeEnabled=FeatureName] attribute long unscopeableExperimentEnabledLongAttribute;
[Unscopeable, RuntimeEnabled=FeatureName] attribute long unscopeableRuntimeEnabledLongAttribute;
[Unscopeable] void unscopeableVoidMethod();
[Unscopeable, RuntimeEnabled=FeatureName] void unscopeableRuntimeEnabledVoidMethod();
@@ -528,6 +536,14 @@ interface TestObject {
[CustomElementCallbacks] void customElementCallbacksVoidMethod();
[DeprecateAs=voidMethod] void deprecatedVoidMethod();
[DoNotCheckSignature] void doNotCheckSignatureVoidMethod();
+ [APIExperimentEnabled=FeatureName, RuntimeEnabled=FeatureName1] void experimentEnabledVoidMethod();
+ [PerWorldBindings, APIExperimentEnabled=FeatureName, RuntimeEnabled=FeatureName1] void perWorldBindingsExperimentEnabledVoidMethod();
+ [APIExperimentEnabled=FeatureName, RuntimeEnabled=FeatureName1] void experimentEnabledOverloadedVoidMethod(DOMString stringArg);
+ [APIExperimentEnabled=FeatureName, RuntimeEnabled=FeatureName1] void experimentEnabledOverloadedVoidMethod(long longArg);
+ [APIExperimentEnabled=FeatureName1, RuntimeEnabled=FeatureName1] void partiallyExperimentEnabledOverloadedVoidMethod(DOMString stringArg);
+ [APIExperimentEnabled=FeatureName2, RuntimeEnabled=FeatureName1] void partiallyExperimentEnabledOverloadedVoidMethod(TestInterface testInterfaceArg);
+ void partiallyExperimentEnabledOverloadedVoidMethod(long longArg, DOMString stringArg);
+ [APIExperimentEnabled=FeatureName3] void partiallyExperimentEnabledOverloadedVoidMethod(long longArg, DOMString stringArg, TestInterface testInterfaceArg);
[ImplementedAs=implementedAsMethodName] void implementedAsVoidMethod();
[MeasureAs=TestFeature] void measureAsVoidMethod();
[Measure] void measureMethod();

Powered by Google App Engine
This is Rietveld 408576698