third_party/WebKit/Source/bindings/scripts/v8_attributes.py - Issue 1531443003: [bindings] Implement an ExperimentEnabled IDL extended attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

Issue 1531443003: [bindings] Implement an ExperimentEnabled IDL extended attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Install interfaces/attributes/methods unconditionally. Use the generated ExperimentalFeature functi… Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/generate_global_constructors.py ('k') | third_party/WebKit/Source/bindings/scripts/v8_interface.py » ('j') | third_party/WebKit/Source/bindings/scripts/v8_interface.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

index 96b8964d46a8f781f270a528c79b2ac3a8f90be0..d8559e82cb534e5c76545c9188820d7c6ed3b481 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

@@ -103,6 +103,9 @@ def attribute_context(interface, attribute):

'activity_logging_world_list_for_getter': v8_utilities.activity_logging_world_list(attribute, 'Getter'), # [ActivityLogging]

'activity_logging_world_list_for_setter': v8_utilities.activity_logging_world_list(attribute, 'Setter'), # [ActivityLogging]

'activity_logging_world_check': v8_utilities.activity_logging_world_check(attribute), # [ActivityLogging]

+ 'api_experiment_name': extended_attributes.get('APIExperimentEnabled'), # [APIExperimentEnabled]

+ 'api_experiment_inherited_enabled': v8_utilities.api_experiment_enabled_function(interface), # [APIExperimentEnabled]

+ 'api_experiment_enabled': v8_utilities.api_experiment_enabled_function(attribute), # [APIExperimentEnabled]

haraken 2015/12/30 00:25:32 Alphabetical order.

Daniel Nishi 2015/12/30 22:05:50 Done.

'argument_cpp_type': idl_type.cpp_type_args(used_as_rvalue_type=True),

'cached_attribute_validation_method': cached_attribute_validation_method,

'conditional_string': conditional_string,

@@ -509,7 +512,7 @@ def is_constructor_attribute(attribute):

def update_constructor_attribute_context(interface, attribute, context):

- context['needs_constructor_getter_callback'] = context['measure_as'] or context['deprecate_as']

+ context['needs_constructor_getter_callback'] = context['measure_as'] or context['deprecate_as'] or context['api_experiment_name']

# When the attribute name is the same as the interface name, do not generate

# callback functions for each attribute and use

# {{cpp_class}}ConstructorAttributeSetterCallback. Otherwise, generate