third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp - Issue 1531443003: [bindings] Implement an ExperimentEnabled IDL extended attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

Issue 1531443003: [bindings] Implement an ExperimentEnabled IDL extended attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More sharing. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/interface_base.cpp ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp » ('j') | third_party/WebKit/Source/core/experiments/Experiments.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

index 9c237a3dad70f479cb53aca8a302bb046eb48605..f504b593056129efe61b1f396fab7fb172cb0488 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp

@@ -31,6 +31,7 @@

#include "bindings/tests/idls/core/TestPartialInterfaceImplementation.h"

#include "core/dom/ContextFeatures.h"

#include "core/dom/Document.h"

+#include "core/experiments/Experiments.h"

#include "core/frame/LocalFrame.h"

#include "core/frame/UseCounter.h"

#include "core/inspector/ConsoleMessage.h"

@@ -2393,7 +2394,7 @@ void V8TestInterface::installV8TestInterfaceTemplate(v8::Local<v8::FunctionTempl

functionTemplate->ReadOnlyPrototype();

v8::Local<v8::Signature> defaultSignature;

- if (!RuntimeEnabledFeatures::featureNameEnabled())

+ if (!(RuntimeEnabledFeatures::featureNameEnabled() && Experiments::isApiEnabled(currentExecutionContext(isolate), "ExperimentName")))

defaultSignature = V8DOMConfiguration::installDOMClassTemplate(isolate, functionTemplate, "TestInterface", V8TestInterfaceEmpty::domTemplate(isolate), V8TestInterface::internalFieldCount, 0, 0, 0, 0, 0, 0);

else

defaultSignature = V8DOMConfiguration::installDOMClassTemplate(isolate, functionTemplate, "TestInterface", V8TestInterfaceEmpty::domTemplate(isolate), V8TestInterface::internalFieldCount,