third_party/WebKit/Source/bindings/templates/interface.cpp - Issue 1531443003: [bindings] Implement an ExperimentEnabled IDL extended attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.cpp

Issue 1531443003: [bindings] Implement an ExperimentEnabled IDL extended attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove 'return undefined and print a message' on constructors. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/scripts/v8_utilities.py ('K') | « third_party/WebKit/Source/bindings/templates/constants.cpp ('k') | third_party/WebKit/Source/bindings/templates/interface_base.cpp » ('j') | third_party/WebKit/Source/bindings/templates/interface_base.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/interface.cpp b/third_party/WebKit/Source/bindings/templates/interface.cpp

index a44d2d110b06e0dbfd8930d396d3763e9fa062da..63fb775e58df93b5986e411c6323f77b29c4bd47 100644

--- a/third_party/WebKit/Source/bindings/templates/interface.cpp

+++ b/third_party/WebKit/Source/bindings/templates/interface.cpp

@@ -903,10 +903,12 @@ if (v8CallBoolean(prototypeObject->HasOwnProperty(context, unscopablesSymbol)))

unscopeables = prototypeObject->Get(context, unscopablesSymbol).ToLocalChecked().As<v8::Object>();

else

unscopeables = v8::Object::New(isolate);

-{% for name, runtime_enabled_function in unscopeables %}

+{% for name, runtime_enabled_function, api_experiment_name in unscopeables %}

{% filter runtime_enabled(runtime_enabled_function) %}

+{% filter api_experiment_enabled(api_experiment_name) %}

unscopeables->CreateDataProperty(context, v8AtomicString(isolate, "{{name}}"), v8::True(isolate)).FromJust();

{% endfilter %}

+{% endfilter %}

{% endfor %}

prototypeObject->CreateDataProperty(context, unscopablesSymbol, unscopeables).FromJust();

{% endmacro %}