Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 153143002: Support Express for 2013 automatic toolchain (Closed)

Created:
6 years, 10 months ago by scottmg
Modified:
6 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Visibility:
Public.

Description

Support Express for 2013 automatic toolchain Pick up setting for Express 2013 to get WDK_DIR set (required for ATL with Express). Add additional "or 2013e" to build/common.gypi, but exclude unneeded workaround for intsafe.h. R=dpranke@chromium.org BUG=323300, 340358 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M build/common.gypi View 2 chunks +4 lines, -2 lines 0 comments Download
M build/gyp_chromium View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 10 months ago (2014-02-04 17:12:55 UTC) #1
Dirk Pranke
lgtm
6 years, 10 months ago (2014-02-04 17:14:23 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 10 months ago (2014-02-04 17:17:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/153143002/1
6 years, 10 months ago (2014-02-04 17:19:08 UTC) #4
scottmg
6 years, 10 months ago (2014-02-04 17:50:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r248747 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698