Issue 153143002: Support Express for 2013 automatic toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 153143002: Support Express for 2013 automatic toolchain (Closed)

Created:
6 years, 10 months ago by scottmg

Modified:
6 years, 10 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Support Express for 2013 automatic toolchain Pick up setting for Express 2013 to get WDK_DIR set (required for ATL with Express). Add additional "or 2013e" to build/common.gypi, but exclude unneeded workaround for intsafe.h. R=dpranke@chromium.org BUG=323300, 340358 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248747

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	build/common.gypi	View		2 chunks	+4 lines, -2 lines	0 comments	Download
	M	build/gyp_chromium	View		1 chunk	+9 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/153143002/1

6 years, 10 months ago (2014-02-04 17:19:08 UTC) #4

scottmg

6 years, 10 months ago (2014-02-04 17:50:09 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r248747 (presubmit successful).