Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1531383002: move ReplacementRange into dart specific contributor (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -169 lines) Patch
M pkg/analysis_server/lib/src/services/completion/completion_core.dart View 2 chunks +31 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 4 chunks +63 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 5 chunks +1 line, -164 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-17 21:12:39 UTC) #2
scheglov
LGTM
5 years ago (2015-12-17 21:16:55 UTC) #3
danrubel
5 years ago (2015-12-17 21:24:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4ee5173f42c9070e1a1010e537741e7bd68f0dd2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698