Add fExternalFormatForTexImage to GrGLGpu::ConfigEntry. Use it in GrGLGpu::uploadTexData.

Add fExternalFormatForTexImage to GrGLGpu::ConfigEntry. Use it in GrGLGpu::uploadTexData.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1531343002

Committed: https://skia.googlesource.com/skia/+/5b30c6f6224f5e9d29ff7060311556ba0eee0fdc

[bsalomon, 2015-12-17 18:49:11]

Description was changed from

==========
Add fExternalFormatForTexImage to GrGLGpu::ConfigEntry. Use it in
GrGLGpu::uploadTexData.
==========

to

==========
Add fExternalFormatForTexImage to GrGLGpu::ConfigEntry. Use it in
GrGLGpu::uploadTexData.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2015-12-17 18:51:40]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, jvanverth@google.com

[jvanverth1, 2015-12-17 19:21:51]

https://codereview.chromium.org/1531343002/diff/20001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1531343002/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:2793: }
What about iOS, BGRA, and ES 3.0? Didn't we see something odd there as well?

[bsalomon, 2015-12-17 19:35:12]

https://codereview.chromium.org/1531343002/diff/20001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1531343002/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:2793: }
On 2015/12/17 19:21:50, jvanverth1 wrote:
> What about iOS, BGRA, and ES 3.0? Didn't we see something odd there as well?

I don't recall that. AFAIK there is no sRGB BGRA format. I think this produces
the same behavior as the previous code: on desktop/ES 3.0+ we will pass GL_RGBA
for the format param to tex[Sub]Image and readPixels. On ES2 we pass
GL_SRGB_ALPHA for format to tex[Sub]Image and GL_RGBA to readPixels.

[jvanverth1, 2015-12-17 20:21:37]

On 2015/12/17 19:35:12, bsalomon wrote:
> https://codereview.chromium.org/1531343002/diff/20001/src/gpu/gl/GrGLGpu.cpp
> File src/gpu/gl/GrGLGpu.cpp (right):
> 
>
https://codereview.chromium.org/1531343002/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
> src/gpu/gl/GrGLGpu.cpp:2793: }
> On 2015/12/17 19:21:50, jvanverth1 wrote:
> > What about iOS, BGRA, and ES 3.0? Didn't we see something odd there as well?
> 
> I don't recall that. AFAIK there is no sRGB BGRA format. I think this produces
> the same behavior as the previous code: on desktop/ES 3.0+ we will pass
GL_RGBA
> for the format param to tex[Sub]Image and readPixels. On ES2 we pass
> GL_SRGB_ALPHA for format to tex[Sub]Image and GL_RGBA to readPixels.

Ack, I misread the variable (thought it said internalFormat). lgtm.

[bsalomon, 2015-12-17 20:21:51]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-12-17 20:21:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531343002/20001

[commit-bot: I haz the power, 2015-12-17 22:17:36]

Description was changed from

==========
Add fExternalFormatForTexImage to GrGLGpu::ConfigEntry. Use it in
GrGLGpu::uploadTexData.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add fExternalFormatForTexImage to GrGLGpu::ConfigEntry. Use it in
GrGLGpu::uploadTexData.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/5b30c6f6224f5e9d29ff7060311556ba0eee0fdc
==========

[commit-bot: I haz the power, 2015-12-17 22:17:36]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5b30c6f6224f5e9d29ff7060311556ba0eee0fdc