Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: pkg/analyzer/test/generated/all_the_rest_test.dart

Issue 1531313002: fix #25280, treat setters as returning void in strong mode (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/generated/all_the_rest_test.dart
diff --git a/pkg/analyzer/test/generated/all_the_rest_test.dart b/pkg/analyzer/test/generated/all_the_rest_test.dart
index 6f3aa5dbbf11eff9dc971b1eb06ebdd86e27336a..3f9c11943ac63d37f3353a07c709b67dcbc6f224 100644
--- a/pkg/analyzer/test/generated/all_the_rest_test.dart
+++ b/pkg/analyzer/test/generated/all_the_rest_test.dart
@@ -5335,7 +5335,7 @@ class ElementBuilderTest extends EngineTestCase {
PropertyAccessorElement accessor = accessors[0];
expect(accessor, isNotNull);
_assertHasDocRange(accessor, 50, 7);
- expect(accessor.hasImplicitReturnType, isFalse);
+ expect(accessor.hasImplicitReturnType, isTrue);
expect(accessor.name, "$functionName=");
expect(declaration.element, same(accessor));
expect(declaration.functionExpression.element, same(accessor));
@@ -5762,7 +5762,7 @@ class ElementBuilderTest extends EngineTestCase {
PropertyAccessorElement setter = field.setter;
expect(setter, isNotNull);
_assertHasDocRange(setter, 50, 7);
- expect(setter.hasImplicitReturnType, isFalse);
+ expect(setter.hasImplicitReturnType, isTrue);
expect(setter.isAbstract, isFalse);
expect(setter.isExternal, isFalse);
expect(setter.isSetter, isTrue);
@@ -5800,7 +5800,7 @@ class ElementBuilderTest extends EngineTestCase {
expect(field.getter, isNull);
PropertyAccessorElement setter = field.setter;
expect(setter, isNotNull);
- expect(setter.hasImplicitReturnType, isFalse);
+ expect(setter.hasImplicitReturnType, isTrue);
expect(setter.isAbstract, isTrue);
expect(setter.isExternal, isFalse);
expect(setter.isSetter, isTrue);
@@ -5839,7 +5839,7 @@ class ElementBuilderTest extends EngineTestCase {
expect(field.getter, isNull);
PropertyAccessorElement setter = field.setter;
expect(setter, isNotNull);
- expect(setter.hasImplicitReturnType, isFalse);
+ expect(setter.hasImplicitReturnType, isTrue);
expect(setter.isAbstract, isFalse);
expect(setter.isExternal, isTrue);
expect(setter.isSetter, isTrue);
« no previous file with comments | « pkg/analyzer/lib/src/generated/static_type_analyzer.dart ('k') | pkg/analyzer/test/generated/resolver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698