Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 1531263004: Reland of [Tracing] Adjust allocation register size for low-end devices (Closed)

Created:
5 years ago by Ruud van Asseldonk
Modified:
5 years ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [Tracing] Adjust allocation register size for low-end devices Original CL: https://crrev.com/1530583003 by seantopping@chromium.org. > This patch limits the size of the allocation register and prevents OOM > errors when running AllocationRegisterTest.OverflowDeathTest on > low-end devices. > > BUG=570242 > > Committed: https://crrev.com/684e479f9a46580b5d5bdcf58944b832f6317dc1 > Cr-Commit-Position: refs/heads/master@{#365905} BUG=570242 TBR=primiano@chromium.org,seantopping@chromium.org Committed: https://crrev.com/895661fb46361b3b272719fd6931ec4c481220be Cr-Commit-Position: refs/heads/master@{#366081}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unintended extra newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M base/trace_event/heap_profiler_allocation_register.h View 3 chunks +6 lines, -1 line 0 comments Download
M base/trace_event/heap_profiler_allocation_register.cc View 1 3 chunks +8 lines, -4 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_register_unittest.cc View 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Ruud van Asseldonk
https://codereview.chromium.org/1531263004/diff/1/base/trace_event/heap_profiler_allocation_register_unittest.cc File base/trace_event/heap_profiler_allocation_register_unittest.cc (right): https://codereview.chromium.org/1531263004/diff/1/base/trace_event/heap_profiler_allocation_register_unittest.cc#newcode210 base/trace_event/heap_profiler_allocation_register_unittest.cc:210: AllocationRegister reg(static_cast<uint32_t>(GetNumCellsPerPage())); I added this cast to fix the ...
5 years ago (2015-12-18 10:36:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531263004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531263004/1
5 years ago (2015-12-18 10:36:37 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-18 10:36:39 UTC) #7
Primiano Tucci (use gerrit)
LGTM https://codereview.chromium.org/1531263004/diff/1/base/trace_event/heap_profiler_allocation_register.cc File base/trace_event/heap_profiler_allocation_register.cc (right): https://codereview.chromium.org/1531263004/diff/1/base/trace_event/heap_profiler_allocation_register.cc#newcode30 base/trace_event/heap_profiler_allocation_register.cc:30: nit: extra newline?
5 years ago (2015-12-18 10:40:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531263004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531263004/20001
5 years ago (2015-12-18 10:45:31 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-18 12:03:27 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-18 12:04:34 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/895661fb46361b3b272719fd6931ec4c481220be
Cr-Commit-Position: refs/heads/master@{#366081}

Powered by Google App Engine
This is Rietveld 408576698