Turn on wasm flags all the time, add a reference from wasm functions to the module.

Turn on wasm flags all the time, add a reference from wasm functions to the module.

Add an internal field to each wasm function to keep a reference to the module. (So the GC can do the right thing when you only hold references to wasm functions but not the module).

Use Realloc carefully, to avoid copying from out of bounds.

Make snprintf use platform independent.

Don't disconnect external arraybuffers provided for the heap.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/7b775118b98eba613ab3a5936f9c489ed7d1b45a
Cr-Commit-Position: refs/heads/master@{#32951}

[bradn, 2015-12-17 12:45:54]

Description was changed from

==========
Turn on wasm flags all the time, add wasm function map prototype.

R=ahaas@chromium.org
BUG=
==========

to

==========
Turn on wasm flags all the time, add a reference from wasm functions to the
module.

Add an internal field to each wasm function to keep a reference to the module.
(So the GC can do the right thing when you only hold references to wasm
functions but not the module).

Use Realloc carefully, to avoid copying from out of bounds.

Make snprintf use platform independent.

Don't disconnect external arraybuffers provided for the heap.

R=ahaas@chromium.org
BUG=
==========

[ahaas, 2015-12-17 12:58:39]

lgtm

[bradn, 2015-12-17 13:00:53]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2015-12-17 13:01:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531243003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531243003/40001

[commit-bot: I haz the power, 2015-12-17 13:20:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 13:20:27]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9100)

[Camillo Bruni, 2015-12-17 13:26:27]

cbruni@chromium.org changed reviewers:
+ cbruni@chromium.org

[Camillo Bruni, 2015-12-17 13:26:27]

lgtm

[bradn, 2015-12-17 13:26:59]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2015-12-17 13:27:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531243003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531243003/40001

[bradn, 2015-12-17 13:27:35]

The CQ bit was unchecked by bradnelson@google.com

[bradn, 2015-12-17 13:29:17]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2015-12-17 13:29:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531243003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531243003/40001

[commit-bot: I haz the power, 2015-12-17 13:31:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 13:31:59]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9103)

[ahaas, 2015-12-17 13:51:02]

lgtm

[Jarin, 2015-12-17 14:45:20]

jarin@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2015-12-17 14:45:21]

lgtm (the Realloc stuff is terrible, but bradn promised to make sure this is
cleaned up.)

[bradn, 2015-12-17 14:45:45]

The CQ bit was checked by bradnelson@google.com

[bradn, 2015-12-17 14:45:45]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/1531243003/#ps60001
(title: "add missing file")

[commit-bot: I haz the power, 2015-12-17 14:45:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531243003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531243003/60001

[commit-bot: I haz the power, 2015-12-17 14:52:43]

Description was changed from

==========
Turn on wasm flags all the time, add a reference from wasm functions to the
module.

Add an internal field to each wasm function to keep a reference to the module.
(So the GC can do the right thing when you only hold references to wasm
functions but not the module).

Use Realloc carefully, to avoid copying from out of bounds.

Make snprintf use platform independent.

Don't disconnect external arraybuffers provided for the heap.

R=ahaas@chromium.org
BUG=
==========

to

==========
Turn on wasm flags all the time, add a reference from wasm functions to the
module.

Add an internal field to each wasm function to keep a reference to the module.
(So the GC can do the right thing when you only hold references to wasm
functions but not the module).

Use Realloc carefully, to avoid copying from out of bounds.

Make snprintf use platform independent.

Don't disconnect external arraybuffers provided for the heap.

R=ahaas@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2015-12-17 14:52:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-12-17 14:52:54]

Description was changed from

==========
Turn on wasm flags all the time, add a reference from wasm functions to the
module.

Add an internal field to each wasm function to keep a reference to the module.
(So the GC can do the right thing when you only hold references to wasm
functions but not the module).

Use Realloc carefully, to avoid copying from out of bounds.

Make snprintf use platform independent.

Don't disconnect external arraybuffers provided for the heap.

R=ahaas@chromium.org
BUG=
==========

to

==========
Turn on wasm flags all the time, add a reference from wasm functions to the
module.

Add an internal field to each wasm function to keep a reference to the module.
(So the GC can do the right thing when you only hold references to wasm
functions but not the module).

Use Realloc carefully, to avoid copying from out of bounds.

Make snprintf use platform independent.

Don't disconnect external arraybuffers provided for the heap.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/7b775118b98eba613ab3a5936f9c489ed7d1b45a
Cr-Commit-Position: refs/heads/master@{#32951}
==========

[commit-bot: I haz the power, 2015-12-17 14:52:55]

Patchset 4 (id:??) landed as
https://crrev.com/7b775118b98eba613ab3a5936f9c489ed7d1b45a
Cr-Commit-Position: refs/heads/master@{#32951}