Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1531243002: Revert of [es6] ship regexp sticky flag. (Closed)

Created:
5 years ago by Michael Hablich
Modified:
5 years ago
Reviewers:
Dan Ehrenberg, Yang
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] ship regexp sticky flag. Reason for revert: This causes compatibility issues, as documented in https://bugs.chromium.org/p/v8/issues/detail?id=4617#c9 Original issue's description: > [es6] ship regexp sticky flag. > > R=littledan@chromium.org > BUG=v8:4342 > LOG=Y > > Committed: https://crrev.com/86c2dd4042dc9ce293e004234eb094f2b51d9640 > Cr-Commit-Position: refs/heads/master@{#32826} TBR=yangguo@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4342 LOG=Y Committed: https://crrev.com/f54ee7bd1496c0486fa87df8db4fdff833e9e220 Cr-Commit-Position: refs/heads/master@{#32932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/flag-definitions.h View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531243002/1
5 years ago (2015-12-17 09:02:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 09:02:30 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f54ee7bd1496c0486fa87df8db4fdff833e9e220 Cr-Commit-Position: refs/heads/master@{#32932}
5 years ago (2015-12-17 09:03:01 UTC) #5
Yang
5 years ago (2015-12-17 09:57:26 UTC) #6
Message was sent while issue was closed.
On 2015/12/17 09:03:01, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/f54ee7bd1496c0486fa87df8db4fdff833e9e220
> Cr-Commit-Position: refs/heads/master@{#32932}

lgtm.

Powered by Google App Engine
This is Rietveld 408576698