Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6099)

Unified Diff: chrome/browser/language_usage_metrics_unittest.cc

Issue 15311006: Added and replaced some UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/language_usage_metrics_unittest.cc
diff --git a/chrome/browser/language_usage_metrics_unittest.cc b/chrome/browser/language_usage_metrics_unittest.cc
index 9a2dbc981bc12e93e6662f02163f2555c696e8a1..68b3e40376b0a2d949182b2dfdf49c730d554a54 100644
--- a/chrome/browser/language_usage_metrics_unittest.cc
+++ b/chrome/browser/language_usage_metrics_unittest.cc
@@ -79,25 +79,3 @@ TEST(LanguageUsageMetricsTest, ParseAcceptLanguages) {
it = language_set.begin();
EXPECT_EQ(ENGLISH, *it);
}
-
-TEST(LanguageUsageMetricsTest, ToLanguageCode) {
- const int SPANISH = 25971;
- const int JAPANESE = 27233;
-
- // Basic case.
- EXPECT_EQ(JAPANESE, LanguageUsageMetrics::ToLanguageCode("ja"));
-
- // Case is ignored.
- EXPECT_EQ(SPANISH, LanguageUsageMetrics::ToLanguageCode("Es"));
-
- // Coutry code is ignored.
- EXPECT_EQ(JAPANESE, LanguageUsageMetrics::ToLanguageCode("ja-JP"));
-
- // Invalid locales are considered as unknown language.
- EXPECT_EQ(0, LanguageUsageMetrics::ToLanguageCode(std::string()));
- EXPECT_EQ(0, LanguageUsageMetrics::ToLanguageCode("1234"));
-
- // "xx" is not acceptable because it doesn't exist in ISO 639-1 table.
- // However, LanguageUsageMetrics doesn't tell what code is valid.
- EXPECT_EQ(30840, LanguageUsageMetrics::ToLanguageCode("xx"));
-}

Powered by Google App Engine
This is Rietveld 408576698