Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2032)

Unified Diff: chrome/browser/language_usage_metrics.h

Issue 15311006: Added and replaced some UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/language_usage_metrics.cc » ('j') | chrome/browser/language_usage_metrics.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/language_usage_metrics.h
diff --git a/chrome/browser/language_usage_metrics.h b/chrome/browser/language_usage_metrics.h
index 72bfec53f85017655e722f7c1c7162907c12af38..13f1337c64ab80ab4c286086c1b09802700033f3 100644
--- a/chrome/browser/language_usage_metrics.h
+++ b/chrome/browser/language_usage_metrics.h
@@ -11,7 +11,6 @@
#include "base/gtest_prod_util.h"
// Methods to record language usage as UMA histograms.
-// Language codes are defined in third_party/cld/languages/proto/languages.pb.h
class LanguageUsageMetrics {
public:
// Records accept languages as a UMA histogram. |accept_languages| is a
@@ -35,17 +34,7 @@ class LanguageUsageMetrics {
static void ParseAcceptLanguages(const std::string& accept_languages,
std::set<int>* languages);
- // Parses |locale| and returns the language code. Returns 0 in case of errors.
- // The language code is calculated from two alphabets. For example, if
- // |locale| is 'en' which represents 'English', the codes of 'e' and 'n' are
- // 101 and 110 respectively, and the language code will be 101 * 256 + 100 =
- // 25966.
- // |locale| should consist of only lower-case letters. This function doesn't
- // check whether |locale| is valid locale or not strictly.
- static int ToLanguageCode(const std::string &locale);
-
FRIEND_TEST_ALL_PREFIXES(LanguageUsageMetricsTest, ParseAcceptLanguages);
- FRIEND_TEST_ALL_PREFIXES(LanguageUsageMetricsTest, ToLanguageCode);
};
#endif // CHROME_BROWSER_LANGUAGE_USAGE_METRICS_H_
« no previous file with comments | « no previous file | chrome/browser/language_usage_metrics.cc » ('j') | chrome/browser/language_usage_metrics.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698