Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3729)

Unified Diff: chrome/common/metrics/metrics_util_unittest.cc

Issue 15311006: Added and replaced some UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/metrics/metrics_util_unittest.cc
diff --git a/chrome/common/metrics/metrics_util_unittest.cc b/chrome/common/metrics/metrics_util_unittest.cc
index 7c21dfd49ec924855217b1c9f4fdbdd076eac4ba..110ce118d0a39fe19bb7bf86a84e867e743e2eb1 100644
--- a/chrome/common/metrics/metrics_util_unittest.cc
+++ b/chrome/common/metrics/metrics_util_unittest.cc
@@ -27,4 +27,26 @@ TEST(MetricsUtilTest, HashName) {
EXPECT_EQ(known_hashes[i].hash_value, HashName(known_hashes[i].name));
}
+TEST(MetricsUtilTest, ToLanguageCode) {
+ const int SPANISH = 25971;
+ const int JAPANESE = 27233;
+
+ // Basic case.
+ EXPECT_EQ(JAPANESE, ToLanguageCode("ja"));
+
+ // Case is ignored.
+ EXPECT_EQ(SPANISH, ToLanguageCode("Es"));
+
+ // Coutry code is ignored.
+ EXPECT_EQ(JAPANESE, ToLanguageCode("ja-JP"));
+
+ // Invalid locales are considered as unknown language.
+ EXPECT_EQ(0, ToLanguageCode(std::string()));
+ EXPECT_EQ(0, ToLanguageCode("1234"));
+
+ // "xx" is not acceptable because it doesn't exist in ISO 639-1 table.
+ // However, LanguageUsageMetrics doesn't tell what code is valid.
+ EXPECT_EQ(30840, ToLanguageCode("xx"));
+}
+
} // namespace metrics

Powered by Google App Engine
This is Rietveld 408576698