Added and replaced some UMAs

chrome/common/metrics/metrics_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_METRICS_METRICS_UTIL_H_
 #define CHROME_COMMON_METRICS_METRICS_UTIL_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 
 namespace metrics {
 
 // Computes a uint32 hash of a given string based on its SHA1 hash. Suitable for
 // uniquely identifying field trial names and group names.
 uint32 HashName(const std::string& name);
 
+// Parses |locale| and returns the language code. Returns 0 in case of errors.
+// The language code is calculated from two alphabets. For example, if
+// |locale| is 'en' which represents 'English', the codes of 'e' and 'n' are
+// 101 and 110 respectively, and the language code will be 101 * 256 + 100 =
+// 25966.
+// |locale| should consist of only lower-case letters. This function doesn't
+// check whether |locale| is valid locale or not strictly.
+int ToLanguageCode(const std::string &locale);

[Ilya Sherman, 2013/05/21 22:53:59]

This is not an appropriate location for this function.  Please move it to a more
granular location.

[hajimehoshi, 2013/05/22 04:19:27]

I'll create chrome/browser/metrics/metrics_util.{cc|h} and move this function
there.

On 2013/05/21 22:53:59, Ilya Sherman wrote:

[Ilya Sherman, 2013/05/22 07:51:36]

This code doesn't belong under metrics/, whether in chrome/browser or
chrome/common.  metrics/ is for much more core metrics code.  Please move this
to somewhere that is specific to language detection or translate.

On 2013/05/22 04:19:27, hajimehoshi wrote:

[hajimehoshi, 2013/05/22 08:08:36]

Thank you for your quick review.  I'll this code to LanguageUsageMetrics as a
static function.

On 2013/05/22 07:51:36, Ilya Sherman wrote:

+
 }  // namespace metrics
 
 #endif  // CHROME_COMMON_METRICS_METRICS_UTIL_H_