Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1531073003: Revert of Remove wasm compile time option and enable wasm behind a runtime flag. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
Reviewers:
titzer, bradn
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove wasm compile time option and enable wasm behind a runtime flag. (patchset #54 id:1050001 of https://codereview.chromium.org/1516753007/ ) Reason for revert: [Sheriff] Some build failures, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/builds/7502 Original issue's description: > Remove wasm compile time option and enable wasm behind a runtime flag. > > R=titzer@chromium.org > BUG= > > Committed: https://crrev.com/153f2bd47cce9d5dfa74074dda34c02731d96924 > Cr-Commit-Position: refs/heads/master@{#32955} TBR=titzer@chromium.org,bradnelson@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/2a09d7f9b50de4ff2dbb72c4dea1446ed30db23c Cr-Commit-Position: refs/heads/master@{#32957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -72 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -21 lines 0 comments Download
M Makefile View 1 chunk +6 lines, -0 lines 0 comments Download
M build/features.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/d8.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 2 chunks +7 lines, -3 lines 0 comments Download
M test/mjsunit/mjsunit.status View 3 chunks +3 lines, -23 lines 0 comments Download
M test/unittests/unittests.gyp View 2 chunks +8 lines, -4 lines 0 comments Download
M tools/gyp/v8.gyp View 3 chunks +25 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Remove wasm compile time option and enable wasm behind a runtime flag.
5 years ago (2015-12-17 17:58:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531073003/1
5 years ago (2015-12-17 17:58:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 17:58:53 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-17 17:59:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a09d7f9b50de4ff2dbb72c4dea1446ed30db23c
Cr-Commit-Position: refs/heads/master@{#32957}

Powered by Google App Engine
This is Rietveld 408576698