Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1531073002: Revert of Unit test for WebMediaPlayerMS (Closed)

Created:
5 years ago by qiangchen
Modified:
5 years ago
Reviewers:
mcasas
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Unit test for WebMediaPlayerMS (patchset #9 id:240001 of https://codereview.chromium.org/1417533006/ ) Reason for revert: Break test. Use of Uninitialized Variable. Original issue's description: > We add a unit test for WebMediaPlayerMS in this CL. > > BUG= > > Committed: https://crrev.com/cb1fbb8a0c10b67e623bdbe57ca82680465c5cbb > Cr-Commit-Position: refs/heads/master@{#365575} TBR=mcasas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/8df20f19c93167c293c4a31f21f1ea2ca1c147e6 Cr-Commit-Position: refs/heads/master@{#365632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -687 lines) Patch
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 3 chunks +4 lines, -7 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 4 chunks +5 lines, -11 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_compositor.h View 4 chunks +2 lines, -12 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_compositor.cc View 2 chunks +2 lines, -18 lines 0 comments Download
D content/renderer/media/webmediaplayer_ms_unittest.cc View 1 chunk +0 lines, -638 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
qiangchen
Created Revert of Unit test for WebMediaPlayerMS
5 years ago (2015-12-16 21:29:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531073002/1
5 years ago (2015-12-16 21:30:22 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-16 21:30:24 UTC) #4
mcasas
lgtm
5 years ago (2015-12-16 21:59:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531073002/1
5 years ago (2015-12-16 22:00:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 22:05:51 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-16 22:06:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8df20f19c93167c293c4a31f21f1ea2ca1c147e6
Cr-Commit-Position: refs/heads/master@{#365632}

Powered by Google App Engine
This is Rietveld 408576698