Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 153103003: Move offset_byte_queue.* from media/mp4 to media/common. (Closed)

Created:
6 years, 10 months ago by damienv1
Modified:
6 years, 10 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move offset_byte_queue.* from media/mp4 to media/common. This is the first step to using OffsetByteQueue in the Mpeg2 TS stream parser. BUG=340426 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248841

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -231 lines) Patch
A + media/formats/common/offset_byte_queue.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + media/formats/common/offset_byte_queue.cc View 1 chunk +1 line, -1 line 0 comments Download
A + media/formats/common/offset_byte_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/formats/mp4/mp4_stream_parser.h View 1 chunk +1 line, -1 line 0 comments Download
D media/formats/mp4/offset_byte_queue.h View 1 chunk +0 lines, -66 lines 0 comments Download
D media/formats/mp4/offset_byte_queue.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D media/formats/mp4/offset_byte_queue_unittest.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M media/media.gyp View 4 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
acolwell GONE FROM CHROMIUM
lgtm % nit https://codereview.chromium.org/153103003/diff/1/media/formats/common/offset_byte_queue.h File media/formats/common/offset_byte_queue.h (right): https://codereview.chromium.org/153103003/diff/1/media/formats/common/offset_byte_queue.h#newcode5 media/formats/common/offset_byte_queue.h:5: #ifndef MEDIA_FORMATS_MP4_OFFSET_BYTE_QUEUE_H_ nit: s/FORMATS_MP4/FORMATS_COMMON/ here and ...
6 years, 10 months ago (2014-02-03 22:29:41 UTC) #1
damienv1
The CQ bit was checked by damienv@chromium.org
6 years, 10 months ago (2014-02-04 01:36:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/damienv@chromium.org/153103003/60001
6 years, 10 months ago (2014-02-04 01:38:09 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 02:44:05 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, telemetry_perf_unittests, unit_tests ...
6 years, 10 months ago (2014-02-04 02:44:05 UTC) #5
damienv1
The CQ bit was checked by damienv@chromium.org
6 years, 10 months ago (2014-02-04 02:52:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/damienv@chromium.org/153103003/60001
6 years, 10 months ago (2014-02-04 02:53:21 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 05:47:41 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222758
6 years, 10 months ago (2014-02-04 05:47:42 UTC) #9
damienv1
The CQ bit was checked by damienv@chromium.org
6 years, 10 months ago (2014-02-04 07:22:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/damienv@chromium.org/153103003/60001
6 years, 10 months ago (2014-02-04 07:24:07 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 09:45:28 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=256364
6 years, 10 months ago (2014-02-04 09:45:29 UTC) #13
damienv1
The CQ bit was checked by damienv@chromium.org
6 years, 10 months ago (2014-02-04 15:59:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/damienv@chromium.org/153103003/60001
6 years, 10 months ago (2014-02-04 16:03:06 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 18:03:04 UTC) #16
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=256663
6 years, 10 months ago (2014-02-04 18:03:04 UTC) #17
damienv1
The CQ bit was checked by damienv@chromium.org
6 years, 10 months ago (2014-02-04 19:39:08 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/damienv@chromium.org/153103003/60001
6 years, 10 months ago (2014-02-04 19:49:06 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/damienv@chromium.org/153103003/60001
6 years, 10 months ago (2014-02-05 00:42:21 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 04:10:10 UTC) #21
Message was sent while issue was closed. 
Change committed as 248841

Powered by Google App Engine
This is Rietveld 408576698