Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: cc/playback/display_list_raster_source.h

Issue 1531013004: cc: Do solid color analysis before scheduling tiles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments updated. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/playback/display_list_raster_source.h
diff --git a/cc/playback/display_list_raster_source.h b/cc/playback/display_list_raster_source.h
index 8c06c8d68637dc5175b18bf8d93ee57ace1a8bc9..261be66e8d7f5cf5e1903a4c7d41e96478d2b958 100644
--- a/cc/playback/display_list_raster_source.h
+++ b/cc/playback/display_list_raster_source.h
@@ -22,15 +22,6 @@ class DrawImage;
class CC_EXPORT DisplayListRasterSource
: public base::RefCountedThreadSafe<DisplayListRasterSource> {
public:
- struct CC_EXPORT SolidColorAnalysis {
- SolidColorAnalysis()
- : is_solid_color(false), solid_color(SK_ColorTRANSPARENT) {}
- ~SolidColorAnalysis() {}
-
- bool is_solid_color;
- SkColor solid_color;
- };
-
static scoped_refptr<DisplayListRasterSource>
CreateFromDisplayListRecordingSource(const DisplayListRecordingSource* other,
bool can_use_lcd_text);
@@ -56,9 +47,9 @@ class CC_EXPORT DisplayListRasterSource
// Analyze to determine if the given rect at given scale is of solid color in
// this raster source.
- void PerformSolidColorAnalysis(const gfx::Rect& content_rect,
+ bool PerformSolidColorAnalysis(const gfx::Rect& content_rect,
float contents_scale,
- SolidColorAnalysis* analysis) const;
+ SkColor* color) const;
// Returns true iff the whole raster source is of solid color.
bool IsSolidColor() const;

Powered by Google App Engine
This is Rietveld 408576698