Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: cc/playback/display_list_raster_source.h

Issue 1531013004: cc: Do solid color analysis before scheduling tiles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test updated. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/debug/rasterize_and_record_benchmark_impl.cc ('k') | cc/playback/display_list_raster_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/display_list_raster_source.h
diff --git a/cc/playback/display_list_raster_source.h b/cc/playback/display_list_raster_source.h
index 377e081ff4d45f5a1764c064c4960f24b5a6ebab..3178460a4f8210a082ded3aa013477510f65628b 100644
--- a/cc/playback/display_list_raster_source.h
+++ b/cc/playback/display_list_raster_source.h
@@ -25,15 +25,6 @@ class DrawImage;
class CC_EXPORT DisplayListRasterSource
: public base::RefCountedThreadSafe<DisplayListRasterSource> {
public:
- struct CC_EXPORT SolidColorAnalysis {
- SolidColorAnalysis()
- : is_solid_color(false), solid_color(SK_ColorTRANSPARENT) {}
- ~SolidColorAnalysis() {}
-
- bool is_solid_color;
- SkColor solid_color;
- };
-
static scoped_refptr<DisplayListRasterSource>
CreateFromDisplayListRecordingSource(const DisplayListRecordingSource* other,
bool can_use_lcd_text);
@@ -57,11 +48,11 @@ class CC_EXPORT DisplayListRasterSource
const gfx::Rect& canvas_rect,
float contents_scale) const;
- // Analyze to determine if the given rect at given scale is of solid color in
- // this raster source.
- void PerformSolidColorAnalysis(const gfx::Rect& content_rect,
+ // Returns whether the given rect at given scale is of solid color in
+ // this raster source, as well as the solid color value.
+ bool PerformSolidColorAnalysis(const gfx::Rect& content_rect,
float contents_scale,
- SolidColorAnalysis* analysis) const;
+ SkColor* color) const;
// Returns true iff the whole raster source is of solid color.
bool IsSolidColor() const;
« no previous file with comments | « cc/debug/rasterize_and_record_benchmark_impl.cc ('k') | cc/playback/display_list_raster_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698