cc: Do solid color analysis before scheduling tiles.

cc/layers/picture_layer_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/picture_layer_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <limits>
 #include <set>
@@ skipping 634 matching lines @@
   // is not cleared after drawing from the layer. However, update_rect() is
   // cleared once the invalidation is drawn, which is useful for debugging
   // visualizations. This method intersects the two to give a more exact
   // representation of what was invalidated that is cleared after drawing.
   return IntersectRegions(invalidation_, update_rect());
 }
 
 ScopedTilePtr PictureLayerImpl::CreateTile(const Tile::CreateInfo& info) {
   int flags = 0;
 
-  // We don't handle solid color masks, so we shouldn't bother analyzing those.
-  // Otherwise, always analyze to maximize memory savings.
-  if (!is_mask_)
-    flags = Tile::USE_PICTURE_ANALYSIS;

[vmpstr, 2015/12/29 21:24:23]

We should keep respecting this flag, since it would break solid color masks

[sohanjg, 2015/12/30 12:45:47]

Acknowledged.

-
   if (contents_opaque())
     flags |= Tile::IS_OPAQUE;
 
   return layer_tree_impl()->tile_manager()->CreateTile(
       info, id(), layer_tree_impl()->source_frame_number(), flags);
 }
 
 const Region* PictureLayerImpl::GetPendingInvalidation() {
   if (layer_tree_impl()->IsPendingTree())
     return &invalidation_;
@@ skipping 570 matching lines @@
 
 bool PictureLayerImpl::IsOnActiveOrPendingTree() const {
   return !layer_tree_impl()->IsRecycleTree();
 }
 
 bool PictureLayerImpl::HasValidTilePriorities() const {
   return IsOnActiveOrPendingTree() && IsDrawnRenderSurfaceLayerListMember();
 }
 
 }  // namespace cc