cc: Do solid color analysis before scheduling tiles.

cc/debug/rasterize_and_record_benchmark_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/debug/rasterize_and_record_benchmark_impl.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/basictypes.h"
@@ skipping 29 matching lines @@
     // Run for a minimum amount of time to avoid problems with timer
     // quantization when the layer is very small.
     LapTimer timer(kWarmupRuns,
                    base::TimeDelta::FromMilliseconds(kTimeLimitMillis),
                    kTimeCheckInterval);
     do {
       SkBitmap bitmap;
       bitmap.allocPixels(SkImageInfo::MakeN32Premul(content_rect.width(),
                                                     content_rect.height()));
       SkCanvas canvas(bitmap);
-      DisplayListRasterSource::SolidColorAnalysis analysis;
+      SkColor color = SK_ColorTRANSPARENT;
 
-      raster_source->PerformSolidColorAnalysis(content_rect, contents_scale,
-                                               &analysis);
+      *is_solid_color = raster_source->PerformSolidColorAnalysis(

[vmpstr, 2015/12/29 21:24:23]

I'm not sure what to do in this case. This is measuring the raster speed. So, if
solid color analysis is no longer a part of raster, then maybe it should move
outside. 

That is, raster will now not consider solid color tiles. This will affect
benchmarks, but reflect the updated behavior. I think things like thread times
benchmarks still capture all of the behavior changes. 

[sohanjg, 2015/12/30 12:45:47]

We are always issuing PlaybackToCanvas which wouldn't check for solid or normal
content. Only while assigning memory to tiles that we change the logic, so we
will still raster them as before, isnt it ?

is_solid_color will only be used for calculating the number of non -solid tiles
rendered. i think it will be same as inside or out of the do-while loop, and
with or without our changes. But, yes we can save some extra analysis call if we
move out.

+          content_rect, contents_scale, &color);
       raster_source->PlaybackToCanvas(&canvas, content_rect, content_rect,
                                       contents_scale);
 
-      *is_solid_color = analysis.is_solid_color;
-
       timer.NextLap();
     } while (!timer.HasTimeLimitExpired());
     base::TimeDelta duration =
         base::TimeDelta::FromMillisecondsD(timer.MsPerLap());
     if (duration < *min_time)
       *min_time = duration;
   }
 }
 
 class FixedInvalidationPictureLayerTilingClient
@@ skipping 146 matching lines @@
       total_memory_usage(0),
       total_layers(0),
       total_picture_layers(0),
       total_picture_layers_with_no_content(0),
       total_picture_layers_off_screen(0) {
 }
 
 RasterizeAndRecordBenchmarkImpl::RasterizeResults::~RasterizeResults() {}
 
 }  // namespace cc