cc: Do solid color analysis before scheduling tiles.

cc/playback/display_list_raster_source.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_PLAYBACK_DISPLAY_LIST_RASTER_SOURCE_H_
 #define CC_PLAYBACK_DISPLAY_LIST_RASTER_SOURCE_H_
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "cc/base/cc_export.h"
 #include "cc/debug/rendering_stats_instrumentation.h"
 #include "cc/playback/display_list_recording_source.h"
 #include "skia/ext/analysis_canvas.h"
 #include "skia/ext/refptr.h"
 #include "third_party/skia/include/core/SkPicture.h"
 
 namespace cc {
 class DisplayItemList;
 class DrawImage;
 
 class CC_EXPORT DisplayListRasterSource
     : public base::RefCountedThreadSafe<DisplayListRasterSource> {
  public:
-  struct CC_EXPORT SolidColorAnalysis {
-    SolidColorAnalysis()
-        : is_solid_color(false), solid_color(SK_ColorTRANSPARENT) {}
-    ~SolidColorAnalysis() {}
-
-    bool is_solid_color;
-    SkColor solid_color;
-  };
-
   static scoped_refptr<DisplayListRasterSource>
   CreateFromDisplayListRecordingSource(const DisplayListRecordingSource* other,
                                        bool can_use_lcd_text);
 
   // Raster a subrect of this RasterSource into the given canvas. It is
   // assumed that contents_scale has already been applied to this canvas.
   // Writes the total number of pixels rasterized and the time spent
   // rasterizing to the stats if the respective pointer is not nullptr.
   // It is assumed that the canvas passed here will only be rasterized by
   // this raster source via this call.
   // virtual for testing.
   virtual void PlaybackToCanvas(SkCanvas* canvas,
                                 const gfx::Rect& canvas_bitmap_rect,
                                 const gfx::Rect& canvas_playback_rect,
                                 float contents_scale) const;
 
   // Similar to above, except that the canvas passed here can (or was already)
   // rasterized into by another raster source. That is, it is not safe to clear
   // the canvas or discard its underlying memory.
   void PlaybackToSharedCanvas(SkCanvas* canvas,
                               const gfx::Rect& canvas_rect,
                               float contents_scale) const;
 
   // Analyze to determine if the given rect at given scale is of solid color in
   // this raster source.
-  void PerformSolidColorAnalysis(const gfx::Rect& content_rect,
+  bool PerformSolidColorAnalysis(const gfx::Rect& content_rect,

[vmpstr, 2016/01/06 19:35:03]

nit: Can you make a comment about the return value?

[sohanjg, 2016/01/07 10:13:00]

Done.

                                  float contents_scale,
-                                 SolidColorAnalysis* analysis) const;
+                                 SkColor* color) const;
 
   // Returns true iff the whole raster source is of solid color.
   bool IsSolidColor() const;
 
   // Returns the color of the raster source if it is solid color. The results
   // are unspecified if IsSolidColor returns false.
   SkColor GetSolidColor() const;
 
   // Returns the size of this raster source.
   gfx::Size GetSize() const;
@@ skipping 77 matching lines @@
                                   const gfx::Rect& canvas_bitmap_rect,
                                   const gfx::Rect& canvas_playback_rect,
                                   float contents_scale) const;
 
   DISALLOW_COPY_AND_ASSIGN(DisplayListRasterSource);
 };
 
 }  // namespace cc
 
 #endif  // CC_PLAYBACK_DISPLAY_LIST_RASTER_SOURCE_H_